Skip to content

Commit 7745530

Browse files
committed
Disable an unreachable error check
Verified by trying to come up with a spec test.
1 parent f55f923 commit 7745530

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

src/ast.hpp

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2186,19 +2186,23 @@ namespace Sass {
21862186
std::string n, Expression_Obj def = 0, bool rest = false)
21872187
: AST_Node(pstate), name_(n), default_value_(def), is_rest_parameter_(rest)
21882188
{
2189-
if (default_value_ && is_rest_parameter_) {
2190-
error("variable-length parameter may not have a default value", pstate_);
2191-
}
2189+
// tried to come up with a spec test for this, but it does no longer
2190+
// get past the parser (it error out earlier). A spec test was added!
2191+
// if (default_value_ && is_rest_parameter_) {
2192+
// error("variable-length parameter may not have a default value", pstate_);
2193+
// }
21922194
}
21932195
Parameter(const Parameter* ptr)
21942196
: AST_Node(ptr),
21952197
name_(ptr->name_),
21962198
default_value_(ptr->default_value_),
21972199
is_rest_parameter_(ptr->is_rest_parameter_)
21982200
{
2199-
if (default_value_ && is_rest_parameter_) {
2200-
error("variable-length parameter may not have a default value", pstate_);
2201-
}
2201+
// tried to come up with a spec test for this, but it does no longer
2202+
// get past the parser (it error out earlier). A spec test was added!
2203+
// if (default_value_ && is_rest_parameter_) {
2204+
// error("variable-length parameter may not have a default value", pstate_);
2205+
// }
22022206
}
22032207
ATTACH_AST_OPERATIONS(Parameter)
22042208
ATTACH_OPERATIONS()

0 commit comments

Comments
 (0)