Merge pull request #986 from mgreter/feature/global-assignments

mgreter · mgreter · commit 937ccf8d23df · 2015-03-27T21:52:33.000+01:00
Implement `!global` assignments
diff --git a/debugger.hpp b/debugger.hpp
@@ -69,7 +69,7 @@ inline void debug_ast(AST_Node* node, string ind = "", Env* env = 0)
         case Complex_Selector::ADJACENT_TO: cerr << "{+}"; break;
         case Complex_Selector::ANCESTOR_OF: cerr << "{ }"; break;
       }
-    cerr << " <" << prettyprint(selector->pstate().token.ws_before()) << "> X <" << prettyprint(selector->pstate().token.ws_after()) << ">" << endl;
+    cerr << " <" << prettyprint(selector->pstate().token.ws_before()) << ">" << endl;
     debug_ast(selector->head(), ind + " ", env);
     debug_ast(selector->tail(), ind + "-", env);
   } else if (dynamic_cast<Compound_Selector*>(node)) {
@@ -81,7 +81,7 @@ inline void debug_ast(AST_Node* node, string ind = "", Env* env = 0)
       << (selector->is_optional() ? " [is_optional]": " -")
       << (selector->has_line_break() ? " [line-break]": " -")
       << (selector->has_line_feed() ? " [line-feed]": " -") <<
-      " <" << prettyprint(selector->pstate().token.ws_before()) << "> X <" << prettyprint(selector->pstate().token.ws_after()) << ">" << endl;
+      " <" << prettyprint(selector->pstate().token.ws_before()) << ">" << endl;
     for(auto i : selector->elements()) { debug_ast(i, ind + " ", env); }
   } else if (dynamic_cast<Propset*>(node)) {
     Propset* selector = dynamic_cast<Propset*>(node);
@@ -105,7 +105,7 @@ inline void debug_ast(AST_Node* node, string ind = "", Env* env = 0)
   } else if (dynamic_cast<Type_Selector*>(node)) {
     Type_Selector* selector = dynamic_cast<Type_Selector*>(node);
     cerr << ind << "Type_Selector " << selector << " <<" << selector->name() << ">>" << (selector->has_line_break() ? " [line-break]": " -") <<
-      " <" << prettyprint(selector->pstate().token.ws_before()) << "> X <" << prettyprint(selector->pstate().token.ws_after()) << ">" << endl;
+      " <" << prettyprint(selector->pstate().token.ws_before()) << ">" << endl;
   } else if (dynamic_cast<Selector_Placeholder*>(node)) {
 
     Selector_Placeholder* selector = dynamic_cast<Selector_Placeholder*>(node);
@@ -187,7 +187,7 @@ inline void debug_ast(AST_Node* node, string ind = "", Env* env = 0)
   } else if (dynamic_cast<Comment*>(node)) {
     Comment* block = dynamic_cast<Comment*>(node);
     cerr << ind << "Comment " << block << " " << block->tabs() <<
-      " <" << prettyprint(block->pstate().token.ws_before()) << "> X <" << prettyprint(block->pstate().token.ws_after()) << ">" << endl;
+      " <" << prettyprint(block->pstate().token.ws_before()) << ">" << endl;
     debug_ast(block->text(), ind + "// ", env);
   } else if (dynamic_cast<If*>(node)) {
     If* block = dynamic_cast<If*>(node);
@@ -322,13 +322,13 @@ inline void debug_ast(AST_Node* node, string ind = "", Env* env = 0)
       (expression->is_delayed() ? " {delayed}" : "") <<
       (expression->sass_fix_1291() ? " {sass_fix_1291}" : "") <<
       (expression->quote_mark() != 0 ? " {qm:" + string(1, expression->quote_mark()) + "}" : "") <<
-      " <" << prettyprint(expression->pstate().token.ws_before()) << "> X <" << prettyprint(expression->pstate().token.ws_after()) << ">" << endl;
+      " <" << prettyprint(expression->pstate().token.ws_before()) << ">" << endl;
   } else if (dynamic_cast<String_Constant*>(node)) {
     String_Constant* expression = dynamic_cast<String_Constant*>(node);
     cerr << ind << "String_Constant : " << expression << " [" << prettyprint(expression->value()) << "]" <<
       (expression->is_delayed() ? " {delayed}" : "") <<
       (expression->sass_fix_1291() ? " {sass_fix_1291}" : "") <<
-      " <" << prettyprint(expression->pstate().token.ws_before()) << "> X <" << prettyprint(expression->pstate().token.ws_after()) << ">" << endl;
+      " <" << prettyprint(expression->pstate().token.ws_before()) << ">" << endl;
   } else if (dynamic_cast<String_Schema*>(node)) {
     String_Schema* expression = dynamic_cast<String_Schema*>(node);
     cerr << ind << "String_Schema " << expression << " " << expression->concrete_type() <<
diff --git a/environment.hpp b/environment.hpp
@@ -40,12 +40,29 @@ namespace Sass {
     bool current_frame_has(const string key) const
     { return !!current_frame_.count(key); }
 
+    void current_frame_set(const string key, T val)
+    { current_frame_[key] = val; }
+
+    void global_frame_set(const string key, T val)
+    { global_frame()->current_frame_[key] = val; }
+
     Environment* grandparent() const
     {
       if(parent_ && parent_->parent_) return parent_->parent_;
       else return 0;
     }
 
+    Environment* global_frame()
+    {
+      Environment* cur = this;
+      // looks like global variables
+      // are in the second last parent
+      while (cur->grandparent()) {
+        cur = cur->parent_;
+      }
+      return cur;
+    }
+
     bool global_frame_has(const string key) const
     {
       if(parent_ && !grandparent()) {
@@ -66,6 +83,7 @@ namespace Sass {
       else                            return current_frame_[key];
     }
 
+#ifdef DEBUG
     void print()
     {
       for (typename map<string, T>::iterator i = current_frame_.begin(); i != current_frame_.end(); ++i) {
@@ -76,6 +94,8 @@ namespace Sass {
         parent_->print();
       }
     }
+#endif
+
   };
 }
 
diff --git a/eval.cpp b/eval.cpp
@@ -64,12 +64,15 @@ namespace Sass {
   Expression* Eval::operator()(Assignment* a)
   {
     string var(a->variable());
-    if (env->has(var)) {
+    if (a->is_global()) {
+      env->global_frame_set(var, a->value()->perform(this));
+    }
+    else if (env->has(var)) {
       Expression* v = static_cast<Expression*>((*env)[var]);
       if (!a->is_guarded() || v->concrete_type() == Expression::NULL_VAL) (*env)[var] = a->value()->perform(this);
     }
     else {
-      env->current_frame()[var] = a->value()->perform(this);
+      env->current_frame_set(var, a->value()->perform(this));
     }
     return 0;
   }
diff --git a/expand.cpp b/expand.cpp
@@ -219,12 +219,15 @@ namespace Sass {
   {
     string var(a->variable());
     Selector* p = selector_stack.size() <= 1 ? 0 : selector_stack.back();
-    if (env->has(var)) {
+    if (a->is_global()) {
+      env->global_frame_set(var, a->value()->perform(eval->with(p, env, backtrace)));
+    }
+    else if (env->has(var)) {
       Expression* v = static_cast<Expression*>((*env)[var]);
       if (!a->is_guarded() || v->concrete_type() == Expression::NULL_VAL) (*env)[var] = a->value()->perform(eval->with(p, env, backtrace));
     }
     else {
-      env->current_frame()[var] = a->value()->perform(eval->with(p, env, backtrace));
+      env->current_frame_set(var, a->value()->perform(eval->with(p, env, backtrace)));
     }
     return 0;
   }
diff --git a/functions.cpp b/functions.cpp
@@ -145,7 +145,9 @@ namespace Sass {
     static mt19937 rand(static_cast<unsigned int>(GetSeed()));
 
     // features
-    static set<string> features;
+    static set<string> features {
+      "global-variable-shadowing"
+    };
 
     ////////////////
     // RGB FUNCTIONS

Original file line number	Diff line number	Diff line change
`@@ -40,12 +40,29 @@ namespace Sass {`
`40`	`40`	`bool current_frame_has(const string key) const`
`41`	`41`	`{ return !!current_frame_.count(key); }`
`42`	`42`
	`43`	`+ void current_frame_set(const string key, T val)`
	`44`	`+ { current_frame_[key] = val; }`
	`45`	`+`
	`46`	`+ void global_frame_set(const string key, T val)`
	`47`	`+ { global_frame()->current_frame_[key] = val; }`
	`48`	`+`
`43`	`49`	`Environment* grandparent() const`
`44`	`50`	`{`
`45`	`51`	`if(parent_ && parent_->parent_) return parent_->parent_;`
`46`	`52`	`else return 0;`
`47`	`53`	`}`
`48`	`54`
	`55`	`+ Environment* global_frame()`
	`56`	`+ {`
	`57`	`+ Environment* cur = this;`
	`58`	`+ // looks like global variables`
	`59`	`+ // are in the second last parent`
	`60`	`+ while (cur->grandparent()) {`
	`61`	`+ cur = cur->parent_;`
	`62`	`+ }`
	`63`	`+ return cur;`
	`64`	`+ }`
	`65`	`+`
`49`	`66`	`bool global_frame_has(const string key) const`
`50`	`67`	`{`
`51`	`68`	`if(parent_ && !grandparent()) {`
`@@ -66,6 +83,7 @@ namespace Sass {`
`66`	`83`	`else return current_frame_[key];`
`67`	`84`	`}`
`68`	`85`
	`86`	`+#ifdef DEBUG`
`69`	`87`	`void print()`
`70`	`88`	`{`
`71`	`89`	`for (typename map<string, T>::iterator i = current_frame_.begin(); i != current_frame_.end(); ++i) {`
`@@ -76,6 +94,8 @@ namespace Sass {`
`76`	`94`	`parent_->print();`
`77`	`95`	`}`
`78`	`96`	`}`
	`97`	`+#endif`
	`98`	`+`
`79`	`99`	`};`
`80`	`100`	`}`
`81`	`101`
Original file line number	Diff line number	Diff line change
`@@ -64,12 +64,15 @@ namespace Sass {`
`64`	`64`	`Expression* Eval::operator()(Assignment* a)`
`65`	`65`	`{`
`66`	`66`	`string var(a->variable());`
`67`		`- if (env->has(var)) {`
	`67`	`+ if (a->is_global()) {`
	`68`	`+ env->global_frame_set(var, a->value()->perform(this));`
	`69`	`+ }`
	`70`	`+ else if (env->has(var)) {`
`68`	`71`	`Expression* v = static_cast<Expression>((env)[var]);`
`69`	`72`	`if (!a->is_guarded() \|\| v->concrete_type() == Expression::NULL_VAL) (*env)[var] = a->value()->perform(this);`
`70`	`73`	`}`
`71`	`74`	`else {`
`72`		`- env->current_frame()[var] = a->value()->perform(this);`
	`75`	`+ env->current_frame_set(var, a->value()->perform(this));`
`73`	`76`	`}`
`74`	`77`	`return 0;`
`75`	`78`	`}`
Original file line number	Diff line number	Diff line change
`@@ -219,12 +219,15 @@ namespace Sass {`
`219`	`219`	`{`
`220`	`220`	`string var(a->variable());`
`221`	`221`	`Selector* p = selector_stack.size() <= 1 ? 0 : selector_stack.back();`
`222`		`- if (env->has(var)) {`
	`222`	`+ if (a->is_global()) {`
	`223`	`+ env->global_frame_set(var, a->value()->perform(eval->with(p, env, backtrace)));`
	`224`	`+ }`
	`225`	`+ else if (env->has(var)) {`
`223`	`226`	`Expression* v = static_cast<Expression>((env)[var]);`
`224`	`227`	`if (!a->is_guarded() \|\| v->concrete_type() == Expression::NULL_VAL) (*env)[var] = a->value()->perform(eval->with(p, env, backtrace));`
`225`	`228`	`}`
`226`	`229`	`else {`
`227`		`- env->current_frame()[var] = a->value()->perform(eval->with(p, env, backtrace));`
	`230`	`+ env->current_frame_set(var, a->value()->perform(eval->with(p, env, backtrace)));`
`228`	`231`	`}`
`229`	`232`	`return 0;`
`230`	`233`	`}`