Skip to content

Commit ac338df

Browse files
authored
Merge pull request #2933 from nschonni/fix--Error-on-empty-min/max-call
fix: Error on empty min/max call
2 parents 2c22d56 + 948f126 commit ac338df

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

src/fn_numbers.cpp

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,11 @@ namespace Sass {
105105
{
106106
List* arglist = ARG("$numbers", List);
107107
Number_Obj least;
108-
for (size_t i = 0, L = arglist->length(); i < L; ++i) {
108+
size_t L = arglist->length();
109+
if (L == 0) {
110+
error("At least one argument must be passed.", pstate, traces);
111+
}
112+
for (size_t i = 0; i < L; ++i) {
109113
Expression_Obj val = arglist->value_at_index(i);
110114
Number_Obj xi = Cast<Number>(val);
111115
if (!xi) {
@@ -123,7 +127,11 @@ namespace Sass {
123127
{
124128
List* arglist = ARG("$numbers", List);
125129
Number_Obj greatest;
126-
for (size_t i = 0, L = arglist->length(); i < L; ++i) {
130+
size_t L = arglist->length();
131+
if (L == 0) {
132+
error("At least one argument must be passed.", pstate, traces);
133+
}
134+
for (size_t i = 0; i < L; ++i) {
127135
Expression_Obj val = arglist->value_at_index(i);
128136
Number_Obj xi = Cast<Number>(val);
129137
if (!xi) {

0 commit comments

Comments
 (0)