Fix stack-overflow in Binary_Expression (#3058)

xzyfer · web-flow · commit bf6ccae23b66 · 2020-02-12T20:12:28.000+11:00
diff --git a/src/parser.cpp b/src/parser.cpp
@@ -2849,6 +2849,13 @@ namespace Sass {
       }
     }
 
+    if (operands.size() > Constants::MaxCallStack) {
+        // XXX: this is never hit via spec tests
+        sass::ostream stm;
+        stm << "Stack depth exceeded max of " << Constants::MaxCallStack;
+        error(stm.str());
+    }
+
     for (size_t S = operands.size(); i < S; ++i) {
       if (String_Schema* schema = Cast<String_Schema>(operands[i])) {
         if (schema->has_interpolants()) {

Original file line number	Diff line number	Diff line change
`@@ -2849,6 +2849,13 @@ namespace Sass {`
`2849`	`2849`	`}`
`2850`	`2850`	`}`
`2851`	`2851`
	`2852`	`+ if (operands.size() > Constants::MaxCallStack) {`
	`2853`	`+ // XXX: this is never hit via spec tests`
	`2854`	`+ sass::ostream stm;`
	`2855`	`+ stm << "Stack depth exceeded max of " << Constants::MaxCallStack;`
	`2856`	`+ error(stm.str());`
	`2857`	`+ }`
	`2858`	`+`
`2852`	`2859`	`for (size_t S = operands.size(); i < S; ++i) {`
`2853`	`2860`	`if (String_Schema* schema = Cast<String_Schema>(operands[i])) {`
`2854`	`2861`	`if (schema->has_interpolants()) {`