Merge pull request #599 from mgreter/feature/precision-option

Add tests for precision option

Author: mgreter

lib/sass_spec/engine_adapter.rb

@@ -43,9 +43,10 @@ def version
   end
 
 
-  def compile(sass_filename, style)
-    require 'open3'
-    stdout, stderr, status = Open3.capture3("#{@command} -t #{style} #{sass_filename}", :binmode => true)
+  def compile(sass_filename, style, precision)
+    require 'open3'
+    cmd = "#{@command} --precision #{precision} -t #{style}"
+    stdout, stderr, status = Open3.capture3("#{cmd} #{sass_filename}", :binmode => true)
     [stdout, stderr, status.exitstatus]
   end
 end
@@ -64,7 +65,7 @@ def version
     Sass::VERSION
   end
 
-  def compile(sass_filename, style)
+  def compile(sass_filename, style, precision)
     require 'sass'
     # overloads STDERR
     stderr = StringIO.new
@@ -75,6 +76,7 @@ def compile(sass_filename, style)
     old_stderr, $stderr = $stderr, stderr
     begin
       Encoding.default_external = "UTF-8"
+      Sass::Script::Value::Number.precision = precision
       css_output = Sass.compile_file(sass_filename.to_s, :style => style.to_sym)
       # strings come back as utf8 encoded
       # internaly we only work with bytes

lib/sass_spec/runner.rb

@@ -66,11 +66,10 @@ def _get_cases
              !File.file?(expected_stdout_file_path.sub(/\.css$/, ".skip")) &&
              filename.include?(@options[:filter])
             clean = File.file?(clean_file_name)
-            cases.push SassSpec::TestCase.new(input.realpath(),
+            cases.push SassSpec::TestCase.new(
+              input.realpath(),
               expected_stdout_file_path,
-              expected_stderr_file_path,
-              expected_status_file_path,
-              output_style, clean,
+              folder, output_style, clean,
               @options[:generate].include?(output_style),
               @options)
           end

lib/sass_spec/test_case.rb

@@ -1,24 +1,42 @@
 # This represents a specific test case.
 class SassSpec::TestCase
-  def initialize(input_scss, expected_css, error_file, status_file, style, clean, gen, options = {})
+  def initialize(input_scss, expected_css, folder, style, clean, gen, options = {})
     @input_path = input_scss
     @expected_path = expected_css
-    @error_path = error_file
-    @status_path = status_file
+    @error_path = File.join(folder, "error")
+    @status_path = File.join(folder, "status")
+    @options_path = File.join(folder, "options")
     @output_style = style
     @clean_test = clean
     @options = options
     @generate = gen
+    @precision = 5
 
     # Probe filesystem once and cache the results
     @should_fail = File.file?(@status_path)
     @verify_stderr = File.file?(@error_path)
+
+    # load options (only precision ATM)
+    if (File.file?(@options_path))
+      File.open(@options_path, "r") do |opt|
+        opt.each_line do |line|
+          if (line =~ /^precision\s*:\s*(\d+)\s*$/)
+            @precision = $1.to_i
+          end
+        end
+      end
+    end
+
   end
 
   def name
     @input_path.dirname.to_s.sub(Dir.pwd + "/", "")
   end
 
+  def precision
+    @precision
+  end
+
   def clean_test
     @clean_test
   end
@@ -64,7 +82,7 @@ def output
       return @output
     end
 
-    stdout, stderr, status = engine.compile(@input_path, @output_style)
+    stdout, stderr, status = engine.compile(@input_path, @output_style, @precision)
 
     if @clean_test
       clean_out = _clean_output(stdout)

spec/libsass-todo-tests/libsass/precision/default/expected.compact.css

@@ -0,0 +1 @@
+test { foo: 0.4999 0; bar: 0.49999 0; baz: 0.5 1; }

spec/libsass-todo-tests/libsass/precision/default/expected.compressed.css

@@ -0,0 +1 @@
+test{foo:0.4999 0;bar:0.49999 0;baz:0.5 1}

spec/libsass-todo-tests/libsass/precision/default/expected.expanded.css

@@ -0,0 +1,5 @@
+test {
+  foo: 0.4999 0;
+  bar: 0.49999 0;
+  baz: 0.5 1;
+}

spec/libsass-todo-tests/libsass/precision/default/expected_output.css

@@ -0,0 +1,4 @@
+test {
+  foo: 0.4999 0;
+  bar: 0.49999 0;
+  baz: 0.5 1; }

spec/libsass-todo-tests/libsass/precision/default/input.scss

@@ -0,0 +1,5 @@
+test {
+  foo: 0.4999 round(0.4999);
+  bar: 0.49999 round(0.49999);
+  baz: 0.499999 round(0.499999);
+}

spec/libsass-todo-tests/libsass/precision/higher/expected.compact.css

@@ -0,0 +1 @@
+test { foo: 0.4999 0; bar: 0.49999 0; baz: 0.499999 0; }

spec/libsass-todo-tests/libsass/precision/higher/expected.compressed.css

@@ -0,0 +1 @@
+test{foo:0.4999 0;bar:0.49999 0;baz:0.499999 0}