Skip to content

Commit a4810b4

Browse files
nex3jathak
andauthored
Update specs to allow unused configurations to go past @forward
Co-authored-by: Jennifer Thakar <[email protected]>
1 parent fb50f17 commit a4810b4

File tree

19 files changed

+583
-493
lines changed

19 files changed

+583
-493
lines changed

spec/core_functions/meta/load_css/error/with.hrx

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -182,16 +182,16 @@ Error: _other.scss was already loaded, so it can't be configured using "with".
182182
<===> multi_configuration/double_load/through_forward/input.scss
183183
@use "sass:meta";
184184
@include meta.load-css("forwarded");
185-
@include meta.load-css("midstream", $with: (a: b));
185+
@include meta.load-css("midstream", $with: (a: b, c: d));
186186

187187
<===> multi_configuration/double_load/through_forward/_midstream.scss
188188
@forward "forwarded";
189189

190-
$a: c !default;
190+
$a: e !default;
191191

192192
<===> multi_configuration/double_load/through_forward/_forwarded.scss
193-
// This file defines no variables, but it still may not be loaded both with and
194-
// without configuration.
193+
// This only throws an error because it defines a configurable variable.
194+
$c: f !default;
195195

196196
<===> multi_configuration/double_load/through_forward/error
197197
Error: This module was already loaded, so it can't be configured using "with".
@@ -202,8 +202,8 @@ Error: This module was already loaded, so it can't be configured using "with".
202202
,--> input.scss
203203
2 | @include meta.load-css("forwarded");
204204
| =================================== original load
205-
3 | @include meta.load-css("midstream", $with: (a: b));
206-
| ================================================== configuration
205+
3 | @include meta.load-css("midstream", $with: (a: b, c: d));
206+
| ======================================================== configuration
207207
'
208208
_midstream.scss 1:1 load-css()
209209
input.scss 3:1 root stylesheet
@@ -280,16 +280,16 @@ Error: _other.scss was already loaded, so it can't be configured using "with".
280280
<===> multi_configuration/use_and_load/through_forward/input.scss
281281
@use "sass:meta";
282282
@use "forwarded";
283-
@include meta.load-css("midstream", $with: (a: b));
283+
@include meta.load-css("midstream", $with: (a: b, c: d));
284284

285285
<===> multi_configuration/use_and_load/through_forward/_midstream.scss
286286
@forward "forwarded";
287287

288-
$a: c !default;
288+
$a: e !default;
289289

290290
<===> multi_configuration/use_and_load/through_forward/_forwarded.scss
291-
// This file defines no variables, but it still may not be loaded both with and
292-
// without configuration.
291+
// This only throws an error because it defines a configurable variable.
292+
$c: f !default;
293293

294294
<===> multi_configuration/use_and_load/through_forward/error
295295
Error: This module was already loaded, so it can't be configured using "with".
@@ -300,8 +300,8 @@ Error: This module was already loaded, so it can't be configured using "with".
300300
,--> input.scss
301301
2 | @use "forwarded";
302302
| ================ original load
303-
3 | @include meta.load-css("midstream", $with: (a: b));
304-
| ================================================== configuration
303+
3 | @include meta.load-css("midstream", $with: (a: b, c: d));
304+
| ======================================================== configuration
305305
'
306306
_midstream.scss 1:1 load-css()
307307
input.scss 3:1 root stylesheet

0 commit comments

Comments
 (0)