Skip to content

Commit ae122bf

Browse files
committed
align with feedback
1 parent 2954f58 commit ae122bf

File tree

3 files changed

+35
-16
lines changed

3 files changed

+35
-16
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ X. Exit testing.
277277
278278
[implementation-specific expectations]: #implementation-specific-expectations
279279
280-
Any option can also be applied to all future occurences of that type of failure
280+
Any option can also be applied to all future occurrences of that type of failure
281281
by adding `!` after it. For example, if you want to mark *all* failing specs as
282282
`:todo` for the current implementation you'd type `I!`.
283283

spec/directives/import/nested.hrx

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -276,12 +276,12 @@ These are regression tests for https://github.com/sass/dart-sass/issues/2588.
276276
}
277277

278278
<===> top_level_include_declaration/without_use/_upstream.scss
279-
@mixin a { b: c }
279+
@mixin b { c: d }
280280
@include a;
281281

282282
<===> top_level_include_declaration/without_use/output.css
283283
.a {
284-
b: c;
284+
c: d;
285285
}
286286

287287
<===> top_level_include_declaration/without_use/warning
@@ -297,20 +297,20 @@ More info and automated migrator: https://sass-lang.com/d/import
297297
================================================================================
298298
<===> top_level_include_declaration/with_use/input.scss
299299
.a {
300-
@import 'upstream';
300+
@import 'midstream';
301301
}
302302

303-
<===> top_level_include_declaration/with_use/_upstream.scss
304-
@use 'other';
305-
@mixin a { b: c }
306-
@include a;
303+
<===> top_level_include_declaration/with_use/_midstream.scss
304+
@use 'upstream';
305+
@mixin b { c: d }
306+
@include b;
307307

308-
<===> top_level_include_declaration/with_use/other.scss
308+
<===> top_level_include_declaration/with_use/_other.scss
309309
// Intentionally empty.
310310

311311
<===> top_level_include_declaration/with_use/output.css
312312
.a {
313-
b: c;
313+
c: d;
314314
}
315315

316316
<===> top_level_include_declaration/with_use/warning
@@ -334,15 +334,15 @@ More info and automated migrator: https://sass-lang.com/d/import
334334

335335
<===> top_level_include_declaration/with_use_two_levels_deep/_upstream2.scss
336336
@use 'other';
337-
@mixin a { b: c }
338-
@include a;
337+
@mixin b { c: d }
338+
@include b;
339339

340340
<===> top_level_include_declaration/with_use_two_levels_deep/other.scss
341341
// Intentionally empty.
342342

343343
<===> top_level_include_declaration/with_use_two_levels_deep/output.css
344344
.a {
345-
b: c;
345+
c: d;
346346
}
347347

348348
<===> top_level_include_declaration/with_use_two_levels_deep/warning

spec/directives/use/error/load.hrx

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -331,18 +331,37 @@ Error: There's already a module with namespace "other".
331331

332332
<===>
333333
================================================================================
334-
<===> top_level_include_declaration/input.scss
334+
<===> top_level_include_declaration/upstream_mixin/input.scss
335335
@use "upstream";
336336
@include upstream.a;
337337

338-
<===> top_level_include_declaration/_upstream.scss
338+
<===> top_level_include_declaration/upstream_mixin/_upstream.scss
339339
@mixin a { b: c }
340340

341-
<===> top_level_include_declaration/error
341+
<===> top_level_include_declaration/upstream_mixin/error
342342
Error: Declarations may only be used within style rules.
343343
,
344344
1 | @mixin a { b: c }
345345
| ^^^^^
346346
'
347347
_upstream.scss 1:12 a()
348348
input.scss 2:1 root stylesheet
349+
350+
<===>
351+
================================================================================
352+
<===> top_level_include_declaration/input_mixin/input.scss
353+
@use 'upstream';
354+
@mixin a { b: c }
355+
@include a;
356+
357+
<===> top_level_include_declaration/input_mixin/_upstream.scss
358+
// Intentionally empty.
359+
360+
<===> top_level_include_declaration/input_mixin/error
361+
Error: Declarations may only be used within style rules.
362+
,
363+
2 | @mixin a { b: c }
364+
| ^^^^^
365+
'
366+
input.scss 2:12 a()
367+
input.scss 3:1 root stylesheet

0 commit comments

Comments
 (0)