fix a static build #224
Open
fix a static build #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this! I guess this will be deployed in the next gem release? For now, I can see that if I add |
|
Any chance we can get this in a release? Having to have a C tool chain on windows for JRuby to install one gem is pretty inconvenient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on Windows,
LIBWINPTHREAD-1.DLLis still linked dynamicallya static build shouldn't depend on external libraries. Especially JRuby should be able to load the static library at runtime without a devkit environment. However, devkit tools are still necessary to build the library on JRuby. see #182 (comment)