New option "output_path" added. #88
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! For parameter documentation, I think it would be good to start a new section under usage. |
|
This is a great addition. Is there any reason why this has stalled? Without this option, source maps where the output file isn't in the same directory as the input file don't appear to be possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native library has a function
sass_option_set_output_pathwhich is attached to ruby innative_context_api.rb. But inengine.rbthis option is not set (why?).However to produce correct source maps, the output path must be known to the native library.
The use of the parameters
:source_map_file,:filenameand:output_pathis shown in thetest_source_map_filenamestest in filetest/engine_test.rb.By the way, all these parameters need to be documented. Where is the right place to put this?