fix: minor type and linter adjustments.

Author: zytegalaxy

benchmarks/__init__.py

@@ -1,2 +1 @@
-# ruff: noqa: D104
 """Benchmark package for python-redux."""

benchmarks/bench_autorun.py

@@ -1,10 +1,13 @@
 
+from dataclasses import field, replace
+
 import pytest
-from redux.main import Store
-from redux.basic_types import BaseAction, StoreOptions
-from dataclasses import replace, field
 from immutable import Immutable
 
+from redux.basic_types import BaseAction, StoreOptions
+from redux.main import Store
+
+
 class State(Immutable):
     value: int
     nested: dict = field(default_factory=dict)
@@ -23,49 +26,48 @@ def reducer(state, action):
 def store():
     return Store(reducer, options=StoreOptions(auto_init=True))
 
-def test_autorun_creation(benchmark, store):
+def test_autorun_creation(benchmark, store) -> None:
     """Benchmark creating autoruns."""
-    
-    def run():
+
+    def run() -> None:
         @store.autorun(lambda s: s.value)
-        def _(val):
+        def _(val) -> None:
             pass
 
     benchmark(run)
 
-def test_autorun_reactivity(benchmark, store):
+def test_autorun_reactivity(benchmark, store) -> None:
     """Benchmark autorun reaction overhead."""
-    
+
     @store.autorun(lambda s: s.value)
-    def _(val):
+    def _(val) -> None:
         pass
-    
-    def run():
+
+    def run() -> None:
         store.dispatch(IncrementAction())
 
     benchmark(run)
 
-def test_autorun_complex_selector(benchmark, store):
+def test_autorun_complex_selector(benchmark, store) -> None:
     """Benchmark autorun with complex selector."""
-    
+
     @store.autorun(lambda s: s.value * 2 + (s.nested.get('a', 0) or 0))
-    def _(val):
+    def _(val) -> None:
         pass
 
-    def run():
+    def run() -> None:
         store.dispatch(IncrementAction())
 
     benchmark(run)
 
-def test_autorun_many_subscribers(benchmark, store):
+def test_autorun_many_subscribers(benchmark, store) -> None:
     """Benchmark notification of many autoruns."""
-    
     for _ in range(100):
         @store.autorun(lambda s: s.value)
-        def _(val):
+        def _(val) -> None:
             pass
 
-    def run():
+    def run() -> None:
         store.dispatch(IncrementAction())
 
     benchmark(run)

benchmarks/bench_combine_reducers.py

@@ -1,17 +1,18 @@
 
 from __future__ import annotations
-import uuid
+
 from typing import Any
+
 import pytest
+
 from redux import (
     BaseAction,
-    BaseEvent,
-    CompleteReducerResult,
     InitAction,
     combine_reducers,
 )
 from redux.basic_types import Immutable
 
+
 class State(Immutable):
     value: int
 
@@ -29,46 +30,46 @@ def create_reducers(count: int):
     return {f'r{i}': counter_reducer for i in range(count)}
 
 @pytest.mark.benchmark(group='combine_reducers_creation')
-def test_creation(benchmark):
+def test_creation(benchmark) -> None:
     reducers = create_reducers(10)
-    
-    def run():
+
+    def run() -> None:
         combine_reducers(State, **reducers)
-        
+
     benchmark(run)
 
 @pytest.mark.benchmark(group='combine_reducers_dispatch')
-def test_dispatch_10_reducers(benchmark):
+def test_dispatch_10_reducers(benchmark) -> None:
     reducers = create_reducers(10)
     reducer, _ = combine_reducers(State, **reducers)
     state = reducer(None, InitAction()).state
     action = IncrementAction()
-    
-    def run():
+
+    def run() -> None:
         reducer(state, action)
-        
+
     benchmark(run)
 
 @pytest.mark.benchmark(group='combine_reducers_dispatch')
-def test_dispatch_50_reducers(benchmark):
+def test_dispatch_50_reducers(benchmark) -> None:
     reducers = create_reducers(50)
     reducer, _ = combine_reducers(State, **reducers)
     state = reducer(None, InitAction()).state
     action = IncrementAction()
-    
-    def run():
+
+    def run() -> None:
         reducer(state, action)
-        
+
     benchmark(run)
 
 @pytest.mark.benchmark(group='combine_reducers_dispatch')
-def test_dispatch_100_reducers(benchmark):
+def test_dispatch_100_reducers(benchmark) -> None:
     reducers = create_reducers(100)
     reducer, _ = combine_reducers(State, **reducers)
     state = reducer(None, InitAction()).state
     action = IncrementAction()
-    
-    def run():
+
+    def run() -> None:
         reducer(state, action)
-        
+
     benchmark(run)

benchmarks/bench_dispatch.py

@@ -1,4 +1,4 @@
-# ruff: noqa: D100, D101, D102, D103, D104, D107
+# ruff: noqa: D102
 """Benchmarks for python-redux Store operations."""
 
 from __future__ import annotations
@@ -126,7 +126,6 @@ def run() -> None:
 
 def test_dispatch_batch(benchmark, store: BenchStore) -> None:
     """Benchmark batch dispatch (list of actions)."""
-
     actions = [IncrementAction() for _ in range(100)]
 
     def run() -> None:
@@ -212,7 +211,6 @@ def run_benchmark() -> None:
     for _ in range(50000):
         store.dispatch(IncrementAction())
 
-    print(f'Final state value: {store.state.value if store.state else None}')
     store.dispatch(FinishAction())
 
 

demo.py

@@ -1,4 +1,4 @@
-# ruff: noqa: D100, D101, D102, D103, D104, D107, A003, T201
+# ruff: noqa: D100, D101, D103, T201
 from __future__ import annotations
 
 import time

profile_optimization.py

@@ -1,8 +1,10 @@
 import cProfile
 import pstats
-from redux.basic_types import BaseAction, StoreOptions
+
+from redux.basic_types import BaseAction
 from redux.main import Store
 
+
 class IncrementAction(BaseAction):
     pass
 
@@ -19,12 +21,11 @@ def reducer(state, action):
 for l in listeners:
     store._subscribe(l)
 
-def run_benchmark():
+def run_benchmark() -> None:
     for _ in range(100):
         store.dispatch(IncrementAction())
 
 # Profile
-print("Running profiling...")
 cProfile.run('run_benchmark()', 'logs/profile_subscribers.prof')
 
 # Print stats

pyproject.toml

@@ -67,6 +67,7 @@ sanity = ["typecheck", "lint", "test"]
 
 [tool.ruff]
 target-version = 'py311'
+extend-exclude = ["*.pyi"]
 
 [tool.ruff.lint]
 select = ['ALL']
@@ -81,6 +82,8 @@ multiline-quotes = "double"
 
 [tool.ruff.lint.per-file-ignores]
 "tests/*" = ["S101", "PLR0915", "PLR2004"]
+"benchmarks/*" = ["S101", "ANN", "D100", "D101", "D103", "D205", "D212", "D400", "D415", "PLR2004", "ARG001"]
+"profile_optimization.py" = ["ANN", "D100", "D101", "D103", "ARG001", "ARG005", "E741", "SLF001"]
 
 [tool.ruff.format]
 quote-style = 'single'
@@ -90,6 +93,7 @@ profile = "black"
 
 [tool.pyright]
 exclude = ['typings', '.venv']
+extraPaths = ["/opt/homebrew/lib/python3.11/site-packages"]
 filterwarnings = 'error'
 
 [tool.pytest.ini_options]