Skip to content

Commit 01976cb

Browse files
committed
remove mock.assert_called_once()
1 parent 8cf725d commit 01976cb

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

tests/unit/test_core.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def test_request():
1717

1818
resp = request('GET', 'example.com', session=mock_sess)
1919

20-
mock_sess.request.assert_called_once()
20+
assert mock_sess.request.call_count == 1
2121
assert isinstance(resp, RestObj)
2222
assert hasattr(resp, '_headers')
2323

@@ -41,7 +41,7 @@ def test_list_items():
4141

4242
resp = list_items()
4343

44-
request.assert_called_once()
44+
assert request.call_count == 1
4545
assert [RestObj()] == resp
4646

4747

@@ -56,7 +56,7 @@ def test_get_item_by_dict():
5656
resp = get_item(target)
5757

5858
assert target == resp
59-
request.assert_not_called()
59+
assert request.call_count == 0
6060

6161

6262
def test_get_item_by_name():
@@ -86,8 +86,8 @@ def test_get_item_by_id():
8686
request.return_value = target
8787
resp = get_item(12345)
8888

89-
is_uuid.assert_called_once()
90-
request.assert_called_once()
89+
assert is_uuid.call_count == 1
90+
assert request.call_count == 1
9191
assert target == resp
9292

9393

@@ -107,7 +107,7 @@ def test_update_item():
107107

108108
target._headers = {'etag': 'abcd'}
109109
resp = update_item(target)
110-
request.assert_called_once()
110+
assert request.call_count == 1
111111
assert ('put', '/widget/12345') == request.call_args[0]
112112
assert target == resp
113113

tests/unit/test_microanalytic_score.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def test_create_python_module():
2727
" return out1, out2"))
2828
create_module(source=source)
2929

30-
post.assert_called_once()
30+
assert post.call_count == 1
3131
json = post.call_args[1].get('json', {})
3232
assert 'text/x-python' == json['type']
3333
assert 'public' == json['scope']

tests/unit/test_model_management.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def test_create_performance_definition():
5656
get_project.return_value['predictionVariable'] = 'predicted'
5757
_ = mm.create_performance_definition('model', 'TestLibrary', 'TestData')
5858

59-
post.assert_called_once()
59+
assert post.call_count == 1
6060
url, data = post.call_args
6161

6262
assert PROJECT['id'] == data['json']['projectId']

tests/unit/test_model_repository.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def test_create_model():
4646
tool=target['tool'],
4747
is_champion=target['champion'],
4848
properties=dict(custom1=123, custom2='somevalue'))
49-
post.assert_called_once()
49+
assert post.call_count == 1
5050
url, data = post.call_args
5151

5252
# dict isn't guaranteed to preserve order
@@ -69,7 +69,7 @@ def test_create_model():
6969
get_project.return_value = {'id': PROJECT_ID}
7070
_ = mr.create_model(copy.deepcopy(target), PROJECT_NAME, description='Updated Model')
7171
target['description'] = 'Updated Model'
72-
post.assert_called_once()
72+
assert post.call_count == 1
7373
url, data = post.call_args
7474

7575
# dicts don't preserve order so property order may not match

0 commit comments

Comments
 (0)