testing & formatting

Author: jlwalke2

src/sasctl/_services/folders.py

@@ -49,8 +49,7 @@ def create_folder(cls, name, parent=None, description=None):
 
             parent_uri = cls.get_link(parent_obj, "self")
             if parent_uri is None:
-                raise ValueError(
-                    f"`parent` folder {parent} does not exist.")
+                raise ValueError(f"`parent` folder {parent} does not exist.")
             parent_uri = parent_uri["uri"]
         else:
             parent_uri = None
@@ -159,12 +158,14 @@ def create_path(cls, folder, description=None):
         if not folder.startswith("/"):
             folder = f"/{folder}"
         path = folder.split("/")
-        for level in range(2, len(path)+1):
+        for level in range(2, len(path) + 1):
 
             current_path = path[0:level]
             name = current_path[-1]
             parent = "/".join(current_path[0:-1]) or None
             new_folder = cls.get_folder("/".join(current_path))
             if not new_folder:
-                new_folder = cls.create_folder(name, parent=parent, description=description)
-        return new_folder
+                new_folder = cls.create_folder(
+                    name, parent=parent, description=description
+                )
+        return new_folder

tests/unit/test_folders.py

@@ -78,6 +78,30 @@ def test_create_folder_with_parent():
                 folders.create_folder(FOLDER_NAME, parent="Doesnt Matter")
 
 
+@mock.patch("sasctl._services.folders.Folders.create_folder")
+@mock.patch("sasctl._services.folders.Folders.get_folder")
+def test_create_path(get_folder, create_folder):
+    get_folder.side_effect = lambda x: x in ["/quests", "/quests/grail"]
+
+    folders.create_path("/quests/grail/knights/ni")
+
+    # Should have been called once for each partial path
+    assert get_folder.call_count == 4
+    assert get_folder.call_args_list[0][0][0] == "/quests"
+    assert get_folder.call_args_list[1][0][0] == "/quests/grail"
+    assert get_folder.call_args_list[2][0][0] == "/quests/grail/knights"
+    assert get_folder.call_args_list[3][0][0] == "/quests/grail/knights/ni"
+
+    # /quests/grail already exists, so should have been called twice
+    # to create last two folders.
+    assert create_folder.call_count == 2
+    assert create_folder.call_args_list[0][0][0] == "knights"
+    assert create_folder.call_args_list[0][1]["parent"] == "/quests/grail"
+
+    assert create_folder.call_args_list[1][0][0] == "ni"
+    assert create_folder.call_args_list[1][1]["parent"] == "/quests/grail/knights"
+
+
 @mock.patch("sasctl.core.Session.request")
 def test_get_folder_by_name(request):
     """Verify that looking up a folder by name works."""