default 10k limit on list_funcs

test perf updates

Author: jlwalke2

CHANGELOG.md

@@ -6,6 +6,7 @@ Unreleased
 
 **Changes**
  - `register_model` task automatically captures installed Python packages.
+ - All `list_xxx` methods return all matching items unless a `limit` parameter is specified.
  - Improved API documentation
 
 

src/sasctl/_services/service.py

@@ -217,6 +217,10 @@ def list_items(cls, filter=None, start=None, limit=None, **kwargs):
                 kwargs['start'] = int(start)
             if limit is not None:
                 kwargs['limit'] = int(limit)
+            else:
+                # Until search is more precise, try to pull all results
+                # Needed until transparent pagination is implemented.
+                kwargs['limit'] = int(1e4)
 
             params = '&'.join(['%s=%s' % (k, quote(str(v), safe='/(),"'))
                                for k, v in six.iteritems(kwargs)])

tests/conftest.py

@@ -70,9 +70,18 @@ def add_placeholder(pattern, string, placeholder, group):
 from .matcher import PartialBodyMatcher
 betamax.Betamax.register_request_matcher(PartialBodyMatcher)
 
+# Replay cassettes only by default
+# Can be overridden as necessary to update cassettes
+# See https://betamax.readthedocs.io/en/latest/record_modes.html for details.
+os.environ.setdefault('SASCTL_RECORD_MODE', 'once')
+if os.environ['SASCTL_RECORD_MODE'] \
+        not in ('once', 'new_episodes', 'all', 'none'):
+    os.environ['SASCTL_RECORD_MODE'] = 'once'
+
 with betamax.Betamax.configure() as config:
     config.cassette_library_dir = "tests/cassettes"
-    config.default_cassette_options['record_mode'] = 'once'
+    config.default_cassette_options['record_mode'] = os.environ[
+        'SASCTL_RECORD_MODE']
     config.default_cassette_options['match_requests_on'] = ['method',
                                                             'redacted_path',
                                                             # 'partial_body',
@@ -207,7 +216,6 @@ def cas_session(request, credentials):
         warnings.simplefilter('ignore')
         cassette_name = _casette_name(request, parametrized=False) + '_swat'
 
-
     # Must have an existing Session for Betamax to record
     recorded_session = requests.Session()
 

tests/integration/test_model_publish.py

@@ -27,19 +27,19 @@ def test_get_publish_destination(self):
         assert dest.destinationType == 'microAnalyticService'
 
     def test_create_cas_destination(self):
-        dest = mp.create_cas_destination('caslocal', 'Public', 'sasctl_models',
+        dest = mp.create_cas_destination('sasctlcas', 'Public', 'sasctl_models',
                                          description='Test CAS publish destination from sasctl.')
 
-        assert dest.name == 'caslocal'
+        assert dest.name == 'sasctlcas'
         assert dest.destinationType == 'cas'
         assert dest.casLibrary == 'Public'
         assert dest.casServerName == 'cas-shared-default'
         assert dest.destinationTable == 'sasctl_models'
         assert dest.description == 'Test CAS publish destination from sasctl.'
 
     def test_create_mas_destination(self):
-        dest = mp.create_mas_destination('maslocal2', 'localhost')
+        dest = mp.create_mas_destination('sasctlmas', 'localhost')
 
-        assert dest.name == 'maslocal2'
+        assert dest.name == 'sasctlmas'
         assert dest.destinationType == 'microAnalyticService'
         assert 'description' not in dest

tests/integration/test_pymas.py

@@ -279,6 +279,6 @@ def test_publish_and_execute(tmpdir):
     result = mas.execute_module_step('sasctl_test', 'score', **x1)
 
     assert result['rc'] == 0
-    assert result['var1'] == 24
+    assert round(result['var1'], 2) == 30.29
     assert result['msg'] is None
 

tests/unit/test_tasks.py

@@ -5,6 +5,9 @@
 # SPDX-License-Identifier: Apache-2.0
 
 import pytest
+from six.moves import mock
+
+from sasctl.core import RestObj
 
 
 def test_sklearn_metadata():
@@ -43,7 +46,6 @@ def test_sklearn_metadata():
 
 
 def test_parse_module_url():
-    from sasctl.core import RestObj
     from sasctl.tasks import _parse_module_url
 
     body = RestObj({'createdBy': 'sasdemo',
@@ -69,4 +71,30 @@ def test_parse_module_url():
          'version': 1})
 
     msg = body.get('log').lstrip('SUCßCESS===')
-    assert _parse_module_url(msg) == '/microanalyticScore/modules/decisiontree'
+    assert _parse_module_url(msg) == '/microanalyticScore/modules/decisiontree'
+
+
+def test_save_performance_project_types():
+    from sasctl.tasks import update_performance
+
+    with mock.patch('sasctl._services.model_repository.ModelRepository''.get_model') as model:
+        with mock.patch('sasctl._services.model_repository.ModelRepository.get_project') as project:
+            model.return_value = RestObj(name='fakemodel', projectId=1)
+
+            # Function is required
+            with pytest.raises(ValueError):
+                project.return_value = {}
+                update_performance(None, None, None)
+
+            # Target Level is required
+            with pytest.raises(ValueError):
+                project.return_value = {'function': 'Prediction'}
+                update_performance(None, None, None)
+
+            # Prediction variable required
+            with pytest.raises(ValueError):
+                project.return_value = {'function': 'Prediction',
+                                        'targetLevel': 'Binary'}
+                update_performance(None, None, None)
+
+    # Check projects w/ invalid properties