Skip to content

Commit 592be54

Browse files
committed
remove test_requirements
1 parent 81ccee4 commit 592be54

File tree

4 files changed

+21
-28
lines changed

4 files changed

+21
-28
lines changed

CONTRIBUTING.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,13 @@ integration testing without requiring a running SAS Viya environment, the
3131
[Betamax](https://pypi.org/project/betamax/) package is used to record and
3232
replay network interactions.
3333

34-
In addition, [Tox](https://tox.readthedocs.io) is used to test
35-
compatibility with different Python version.
34+
In addition, [Tox](https://tox.readthedocs.io) is used to automating development tasks
35+
such as testing, linting, and building documentation.
3636

3737
All packages required for development and testing are listed in
38-
[test_requirements.txt](test_requirements.txt) and can be easily installed with
39-
```
40-
pip install -r test_requirements.txt
41-
```
42-
38+
[tox.ini](tox.ini), but it should be unecessary to install these manually. Running `tox`
39+
from the project root directory will automatically build virtual environments for all
40+
Python interpreters found on the system and then install the required packages in those environments.
4341

4442
Before a pull request will be accepted:
4543
- contributions must pass existing regression tests located in tests/

doc/index.rst

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,7 @@ If not already present, these packages will be downloaded and install automatica
3333
The following additional packages are recommended for full functionality:
3434

3535
- swat
36-
37-
38-
All required and recommended packages are listed in `requirements.txt` and can be installed easily with::
39-
40-
pip install -r requirements.txt
36+
- kerberos
4137

4238

4339
Installation
@@ -47,10 +43,14 @@ For basic functionality::
4743

4844
pip install sasctl
4945

50-
For full functionality::
5146

47+
Functionality that depends on additional packages can be installed using the following::
48+
49+
pip install sasctl[swat]
50+
pip install sasctl[kerberos]
5251
pip install sasctl[all]
5352

53+
5454
Quickstart
5555
----------
5656

@@ -370,11 +370,11 @@ the copyright to your contribution, this simply gives us permission to use and r
370370
part of the project.
371371

372372
1. Fork the repository
373-
#. Ensure you're environment has the necessary packages:
373+
#. Run all unit and integration tests and ensure they pass. This can be easily accomplished by running the following:
374374

375-
:command:`pip install -r test_requirements.txt`
375+
:command:`tox`
376376

377-
3. Run all unit and integration tests and ensure they pass. If any tests fail, you should investigate and correct the failure *before* making any changes.
377+
3. If any tests fail, you should investigate and correct the failure *before* making any changes.
378378
#. Make your code changes
379379
#. Include new tests that validate your changes
380380
#. Rerun all unit and integration tests and ensure they pass.

src/sasctl/tasks.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,15 +236,20 @@ def publish_model(model, destination, code=None, max_retries=60,
236236
# Response for publish request includes link to check publish log
237237
job = mr._monitor_job(publish_req)
238238

239+
# Wait for status
240+
# If job failed & overwrite -> check type of destination
241+
# delete model from destination
242+
# publish again
243+
239244
if job.state.lower() == 'failed':
240245
pass
241246

242247
log = request_link(job, 'publishingLog')
243248
msg = log.get('log').lstrip('SUCCESS===')
244249

245250
# As of Viya 3.4 MAS converts module names to lower case.
246-
# Since we can't rely on the request module name being preserved, try to parse the URL out of the response
247-
# so we can retrieve the created module.
251+
# Since we can't rely on the request module name being preserved, try to
252+
# parse the URL out of the response so we can retrieve the created module.
248253
try:
249254
details = json.loads(msg)
250255

test_requirements.txt

Lines changed: 0 additions & 10 deletions
This file was deleted.

0 commit comments

Comments
 (0)