Fixed bug in create_performance_definition regarding passing in model and project

Author: djm21

src/sasctl/_services/model_management.py

@@ -204,13 +204,22 @@ def create_performance_definition(
 
         # Separate single models from multiple models
         if not isinstance(models, list):
-            models = mr.get_model(models)
+            models = [models]
+        if project:
+            project = mr.get_project(project)
+            project_models = mr.get(f'/projects/{project.id}/models')
+            project_models = [m for m in project_models if m.name in models]
+            models = project_models
+            # Necessary to eventually provide variables to the performance definition
+            models[0] = mr.get_model(project_models[0].id)
         else:
             # Collect all models into a list. This converts the PagedList response from mr.list_models to a normal list.
             for i, model in enumerate(models):
                 models[i] = mr.get_model(model)
-        if not project:
             project = mr.get_project(models[0].projectId)
+            # Ensures that all models are in the same project
+            if not all([model.projectId == project.id for model in models]):
+                raise ValueError("Not all models are contained within the same project. Try specifying a project.")
 
         # Performance data cannot be captured unless certain project properties have been configured.
         for required in ["targetVariable", "targetLevel"]: