Removed lxml

Author: InvalidPointer

src/sasctl/utils/pyml2ds/connectors/ensembles/pmml.py

@@ -1,9 +1,4 @@
-try:
-    from lxml import objectify
-except ImportError:
-    objectify = None
-
-from sasctl.utils.pyml2ds.basic.tree import TreeParser
+from pyml2ds.basic.tree import TreeParser
 from .core import EnsembleParser
 
 
@@ -69,9 +64,6 @@ def __init__(self, tree_root):
             i = elem.tag.find('}')
             if i >= 0:
                 elem.tag = elem.tag[i+1:]
-        if objectify is None:
-            raise RuntimeError("Lxml is not installed. Lxml is needed to parse xml files.") 
-        objectify.deannotate(tree_root, cleanup_namespaces=True)
 
         self._forest = tree_root.find('MiningModel/Segmentation')[0].find('MiningModel')
 

src/sasctl/utils/pyml2ds/pyml2ds.py

@@ -1,9 +1,5 @@
 import sys
-
-try:
-    from lxml import etree
-except ImportError:
-    etree = None
+import xml.etree.ElementTree as etree
 
 try:
     import pickle
@@ -36,7 +32,7 @@ def _check_type(model):
         parser = LightgbmParser(model.booster_)
     elif lightgbm and isinstance(model, lightgbm.basic.Booster):
         parser = LightgbmParser(model)
-    elif etree and isinstance(model, etree._ElementTree):
+    elif etree and isinstance(model, etree.ElementTree):
         parser = PmmlParser(model.getroot())
     else:
         raise RuntimeError("Unknown booster type: %s. Compatible types are: %s. Check if corresponding library is installed." % type(model).__name__)
@@ -60,8 +56,6 @@ def pyml2ds(inFile, outFile, outVarName="P_TARGET", test=False):
     # Load model file
     ext = ".pmml"
     if inFile[-len(ext):] == ext:
-        if etree is None:
-            raise RuntimeError("Found pmml file but lxml is not installed. Lxml is needed to parse xml files.") 
         model = etree.parse(inFile)
     else:
         with open(inFile, 'rb') as mf:

tox.ini

@@ -56,7 +56,6 @@ deps =
     tests: kerberos ; platform_system != "Windows"
     tests: xgboost
     tests: lightgbm
-    tests: lxml
     codecov: codecov >= 1.4.0
     doc: sphinx == 1.8