bugfix: handle bad JSON version info

Author: jlwalke2

CHANGELOG.md

@@ -1,6 +1,7 @@
 Unreleased
 ----------
- -
+**Bugfixes**
+ - Fixed an issue where invalid HTTP responses could cause an error when using `Session.version_info()`.
 
 v1.8.2 (2023-01-30)
 -------------------

src/sasctl/core.py

@@ -835,6 +835,11 @@ def version_info(self):
             r = self.get("/licenses/grants")
             release = r.json().get("release")
 
+            # If JSON response was not properly formatted then do not continue
+            # NOTE: response can be logged & debugged with .add_logger()
+            if release is None:
+                return None
+
             # Convert 'V03' and 'V04' to just 3 or 4.
             major_version = int(release.upper().lstrip("V"))
 

tests/unit/test_session.py

@@ -435,3 +435,37 @@ def test_as_swat():
                         username="testuser",
                         password=None,
                     )
+
+
+@mock.patch("sasctl.core.Session._get_authorization_token")
+@mock.patch("sasctl.core.Session.get")
+def test_version_info_35(get, _):
+    """Verify that Session.version_info() makes the correct HTTP call."""
+    from sasctl.core import VersionInfo
+    s = Session("example.com", "user", "password")
+
+    get.return_value.status_code = 200
+    get.return_value.json.return_value = {"release": "V03"}
+
+    version = s.version_info()
+
+    assert get.call_count == 1
+
+    url, params = get.call_args
+    assert url[0] == '/licenses/grants'
+
+    assert isinstance(version, VersionInfo)
+    assert version.major == 3
+
+
+@mock.patch("sasctl.core.Session._get_authorization_token")
+@mock.patch("sasctl.core.Session.get")
+def test_version_info_invalid_response(get, _):
+    """Verify that Session.version_info() returns None if the HTTP response is invalid."""
+    s = Session("example.com", "user", "password")
+
+    get.return_value.status_code = 200
+    get.return_value.json.return_value = {"not_a_release": "V03"}
+
+    version = s.version_info()
+    assert version is None