Skip to content

Commit f00d94e

Browse files
make review suggested changes missed in the previous commit
1 parent 351dbad commit f00d94e

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

src/sasctl/_services/cas_management.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,11 @@ def list_sessions(cls, query_params: dict = None, server: str = None):
123123
else:
124124
query_params={}
125125

126-
sesslist = cls.get(
127-
"/servers/%s/sessions" % (server),
126+
sess_list = cls.get(
127+
"/servers/%s/sessions" %server,
128128
params = query_params
129129
)
130-
return sesslist
130+
return sess_list
131131

132132
@classmethod
133133
def create_session(cls, properties: dict, server: str = None):
@@ -457,9 +457,9 @@ def update_state_table(
457457
458458
Parameters
459459
----------
460-
value : str, required
460+
value : str
461461
State to which to set the table. Valid values include `loaded` or `unloaded`.
462-
name : str, required
462+
name : str
463463
Name of the table.
464464
caslib : str, optional
465465
Name of the caslib. Defaults to 'Samples'.
@@ -523,7 +523,7 @@ def update_state_table(
523523
return tbl
524524

525525
@classmethod
526-
def promote_table(cls, name: str, sessId: str, caslib: str, server: str = None):
526+
def promote_table(cls, name: str, sess_id: str, caslib: str, server: str = None):
527527
"""Changes the scope of a loaded CAS table from session to global scope.
528528
Operation valid only on a session table.
529529
Promote target is the same Caslib that contains the session table.
@@ -532,7 +532,7 @@ def promote_table(cls, name: str, sessId: str, caslib: str, server: str = None):
532532
----------
533533
name : str
534534
Name of the table.
535-
sessId: str
535+
sess_id: str
536536
The session ID
537537
caslib : str
538538
Name of the caslib.
@@ -547,7 +547,7 @@ def promote_table(cls, name: str, sessId: str, caslib: str, server: str = None):
547547
"""
548548
server = server or DEFAULT_SERVER
549549

550-
query = {"value": "global", "sessionId": sessId}
550+
query = {"value": "global", "sessionId": sess_id}
551551

552552
tbl = cls.put(
553553
"/servers/%s/caslibs/%s/tables/%s/scope" % (server, caslib, name),
@@ -562,7 +562,7 @@ def save_table(
562562
name: str,
563563
caslib: str,
564564
properties: dict = None,
565-
sessId: str = None,
565+
sess_id: str = None,
566566
server: str = None,
567567
):
568568
"""Saves a CAS table to a source table
@@ -571,11 +571,11 @@ def save_table(
571571
----------
572572
name : str
573573
Name of the table.
574-
sessId: str
574+
sess_id: str
575575
The session ID
576576
caslib : str
577577
Name of the caslib.
578-
propertes : dict, optional
578+
properties : dict, optional
579579
Properties of the table.
580580
Valid keys are `caslibName`, `format`, `replace`,
581581
`compress`, `tableName`, `sourceTableName`, `parameters`.
@@ -602,7 +602,7 @@ def save_table(
602602
else:
603603
properties = {}
604604

605-
query = {"sessionId": sessId} if sessId else {}
605+
query = {"sessionId": sess_id} if sess_id else {}
606606

607607
sess = cls.post(
608608
"/servers/%s/caslibs/%s/tables/%s" % (server, caslib, name),
@@ -628,9 +628,10 @@ def del_table(
628628
name : str
629629
Name of the table.
630630
query_params : dict
631-
Query parameters. Note that some are required.
631+
Query parameters.
632632
The allowed query parameters are `sessionId`,
633633
`sourceTableName`, `quiet`, `removeAcs`.
634+
Note that the last three are required.
634635
caslib : str
635636
Name of the caslib. Defaults to 'Samples'
636637
server : str

0 commit comments

Comments
 (0)