Skip to content

Commit 30967c3

Browse files
committed
Cleaned up CASTable.rename and tests
1 parent 365524f commit 30967c3

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

swat/cas/table.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5976,6 +5976,7 @@ def rename(self, columns, errors='ignore', **kwargs):
59765976
-------
59775977
:class:`CASTable`
59785978
'''
5979+
59795980
#Columns is a dict:
59805981
alterTable = []
59815982
if isinstance(columns, dict):

swat/tests/cas/test_table.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5182,6 +5182,7 @@ def test_rename(self):
51825182
makeCol = tbl['Make']
51835183
self.assertTrue(any(col in 'Make' for col in list(tbl.columns)))
51845184
tbl.rename({'Make': 'Manufacturer'})
5185+
# We use inplace=True as that's what CASTable.rename is doing
51855186
df.rename(columns={'Make': 'Manufacturer'}, inplace=True)
51865187
# No column named "Make" and a column named "Manufacturer"
51875188
self.assertFalse(any(col in 'Make' for col in list(tbl.columns)))
@@ -5203,6 +5204,7 @@ def test_rename(self):
52035204
# Rename by name for col that doesn't exist
52045205
# errors='ignore'
52055206
originalCols = list(copy.deepcopy(tbl.columns))
5207+
# This column doesn't exist, so it'll just ignore it
52065208
tbl.rename({'nope': 'nuh uh'})
52075209
df.rename(columns={'nope': 'nuh uh'}, inplace=True)
52085210
self.assertFalse(any(col in 'nope' for col in list(tbl.columns)))
@@ -5212,6 +5214,7 @@ def test_rename(self):
52125214
# Rename by name for col that doesn't exist
52135215
# errors='raise'
52145216
with self.assertRaises(KeyError):
5217+
# This column doesn't exist and errors='raise', it'll raise an exception
52155218
tbl.rename(tbl.rename({'nope': 'nuh uh'}, errors='raise'))
52165219

52175220
def test_reset_index(self):

0 commit comments

Comments
 (0)