Skip to content

Commit b552762

Browse files
ajbudlongAndrewShakinovsky-SAS
authored andcommitted
* Add README location in connection message. Alternatively the message could reference the project name instead if that's preferable.
* Indicate that the path to the CA certificate bundle location must be accessible from within the Airflow pods. * Include instructions that the SAS Viya ingress must have an inbound security rule to allow access for Airflow.
1 parent 2fdc272 commit b552762

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,12 @@ In order to connect to SAS Viya from the Airflow operator, you will need to crea
3838
Please be aware of security considerations when storing sensitive information in a
3939
connection. Consult https://airflow.apache.org/docs/apache-airflow/stable/security/index.html for details.
4040
TLS verification can be disabled (not recommended) by specifying the following in
41-
the extra field `{"ssl_certificate_verification": false }`
41+
the extra field `{"ssl_certificate_verification": false }`.
42+
4243
In addition, a custom TLS CA certificate bundle file can be used as follows:
43-
`{"ssl_certificate_verification": "/path/to/trustedcerts.pem"}`
44+
`{"ssl_certificate_verification": "/path/to/trustedcerts.pem"}`. Note that the path used for the CA certificate bundle must reference a location within the Airflow pods.
45+
46+
Inbound security rules must allow communication from the Airflow web server pod through the ingress defined for SAS Viya. Connection timeout errors might occur if the rule is not in place.
4447

4548
### Running a DAG with a SAS provider
4649
See example files in the src/sas_airflow_provider/example_dags directory. These dags can be modified and

src/sas_airflow_provider/hooks/sas.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def _create_session_for_connection(self, http_timeout=None):
7979
payload["username"] = self.login
8080
payload["password"] = self.password
8181

82-
self.log.info("Get oauth token (see README if this crashes)")
82+
self.log.info("Get oauth token (see the the https://github.com/sassoftware/sas-airflow-provider?tab=readme-ov-file#create-a-connection-to-sas if this crashes)")
8383
response = requests.post(
8484
f"{self.host}/SASLogon/oauth/token",
8585
data=payload,

0 commit comments

Comments
 (0)