fix: IaC Azure requires 'temporary_name_for_rotation' during update (#502)

Signed-off-by: David.Houck <[email protected]>

Author: dhoucgitter

modules/aks_node_pool/main.tf

@@ -28,14 +28,18 @@ resource "azurerm_kubernetes_cluster_node_pool" "autoscale_node_pool" {
   priority                     = var.community_priority
   eviction_policy              = var.community_eviction_policy
   spot_max_price               = var.community_spot_max_price
+  temporary_name_for_rotation  = substr("t${var.node_pool_name}", 0, 12)
 
   lifecycle {
     ignore_changes = [node_count]
   }
 
-  linux_os_config {
-    sysctl_config {
-      vm_max_map_count = try(var.linux_os_config.sysctl_config.vm_max_map_count,null)
+  dynamic "linux_os_config" {
+    for_each = var.linux_os_config[*]
+    content {
+      sysctl_config {
+        vm_max_map_count = var.linux_os_config.sysctl_config.vm_max_map_count
+      }
     }
   }
 }
@@ -64,9 +68,14 @@ resource "azurerm_kubernetes_cluster_node_pool" "static_node_pool" {
   priority                     = var.community_priority
   eviction_policy              = var.community_eviction_policy
   spot_max_price               = var.community_spot_max_price
-  linux_os_config {
-    sysctl_config {
-      vm_max_map_count = try(var.linux_os_config.sysctl_config.vm_max_map_count,null)
+  temporary_name_for_rotation  = substr("t${var.node_pool_name}", 0, 12)
+
+  dynamic "linux_os_config" {
+    for_each = var.linux_os_config[*]
+    content {
+      sysctl_config {
+        vm_max_map_count = var.linux_os_config.sysctl_config.vm_max_map_count
+      }
     }
   }
 }

modules/azurerm_vm/main.tf

@@ -107,5 +107,9 @@ resource "azurerm_linux_virtual_machine" "vm" {
 
   tags = var.tags
 
+  lifecycle {
+    ignore_changes = [ identity ]
+  }
+
   depends_on = [azurerm_network_interface_security_group_association.vm_nic_sg]
 }