fix: Conditionally assign zone attributes only if multizone detected for storage_type_backend="netapp" (#327)

* fix: Conditionally assign zone attributes only if multizone detected for storage_type_backend="netapp"

Author: umeshk20

main.tf

@@ -321,6 +321,7 @@ module "google_netapp" {
   protocols          = var.netapp_protocols
   volume_path        = "${var.prefix}-${var.netapp_volume_path}"
   allowed_clients    = join(",", [local.gke_subnet_cidr, local.misc_subnet_cidr])
+  default_nodepool_locations = var.default_nodepool_locations
   depends_on         = [ module.gke ]
 
   community_netapp_networking_components_enabled = var.community_netapp_networking_components_enabled

modules/google_netapp/locals.tf

@@ -0,0 +1,8 @@
+locals {
+  # Determine if deployment is multi-zone (either regional or multiple zones)
+  is_multizone = length(split(",", var.default_nodepool_locations)) > 1
+
+  # Derive primary/replica zones only when multizone is enabled
+  primary_zone = local.is_multizone ? split(",", var.default_nodepool_locations)[0] : null
+  replica_zone = local.is_multizone && length(split(",", var.default_nodepool_locations)) > 1 ? split(",", var.default_nodepool_locations)[1] : null
+}

modules/google_netapp/main.tf

@@ -46,6 +46,10 @@ resource "google_netapp_storage_pool" "netapp-tf-pool" {
   capacity_gib  = var.capacity_gib
   network       = var.network
 
+  # Conditionally assign zone attributes only if multizone detected
+  zone         = local.is_multizone && local.primary_zone != null ? local.primary_zone : null
+  replica_zone = local.is_multizone && local.replica_zone != null ? local.replica_zone : null
+
   lifecycle {
     ignore_changes = [network]
   }

modules/google_netapp/variables.tf

@@ -53,9 +53,14 @@ variable "netapp_subnet_cidr" {
   default     = "192.168.5.0/24"
 }
 
+variable "default_nodepool_locations" {
+  description = "Comma-separated list of default node pool locations"
+  type        = string
+}
+
 # Community Contribution
 variable "community_netapp_networking_components_enabled" {
   description = "Community Contribution. Enable/Disable the deployment of Networking components for Netapp resources. Enabled by default."
   type        = bool
   default     = true
-}
+}