Skip to content

Conversation

@gsmith-sas
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors
'shellcheck -e SC1004' found no issues.

shfmt errors

'shfmt -s -i 4 -bn -sr -ln bash' returned error 1 finding the following formatting issues:

----------
diff logging/bin/remove_openshift_artifacts.sh.orig logging/bin/remove_openshift_artifacts.sh
--- logging/bin/remove_openshift_artifacts.sh.orig
+++ logging/bin/remove_openshift_artifacts.sh
@@ -25,7 +25,6 @@
     fi
 fi
 
-
 # remove custom OpenShift SCC
 oc delete scc v4mlogging --ignore-not-found
 oc delete scc v4m-logging-v2 --ignore-not-found
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt -s -i 4 -bn -sr -ln bash -w filename


@gsmith-sas gsmith-sas requested a review from vishaanS October 29, 2025 19:29
Copy link
Collaborator

@vishaanS vishaanS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic LGTM

@gsmith-sas gsmith-sas merged commit 8563d86 into main Nov 11, 2025
2 checks passed
@gsmith-sas gsmith-sas deleted the ospreq branch November 11, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants