Skip to content

Commit 49d749e

Browse files
Scott DoverScott Dover
authored andcommitted
chore: respond to code review
Signed-off-by: Scott Dover <[email protected]>
1 parent c9b4fd9 commit 49d749e

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

client/src/connection/itc/ItcLibraryAdapter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// SPDX-License-Identifier: Apache-2.0
33
import { l10n } from "vscode";
44

5-
import { SortModelItem } from "ag-grid-community";
5+
import type { SortModelItem } from "ag-grid-community";
66
import { ChildProcessWithoutNullStreams } from "child_process";
77

88
import { onRunError } from "../../commands/run";

client/src/connection/itc/script.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ class SASRunner{
303303
Write-Host $(ConvertTo-Json -Depth 10 -InputObject $result -Compress)
304304
}
305305
306-
[object[]] GetColumnData([string]$libname, [string]$memname) {
306+
[void]GetColumns([string]$libname, [string]$memname) {
307307
$objRecordSet = New-Object -comobject ADODB.Recordset
308308
$objRecordSet.ActiveConnection = $this.dataConnection
309309
$query = @"
@@ -338,12 +338,6 @@ class SASRunner{
338338
$parsedRows += $parsedRow
339339
}
340340
341-
return $parsedRows
342-
}
343-
344-
[void]GetColumns([string]$libname, [string]$memname) {
345-
$parsedRows = $this.GetColumnData($libname, $memname)
346-
347341
Write-Host $(ConvertTo-Json -Depth 10 -InputObject $parsedRows -Compress)
348342
}
349343
@@ -606,7 +600,7 @@ class SASRunner{
606600
$objRecordSet = New-Object -comobject ADODB.Recordset
607601
$objRecordSet.ActiveConnection = $this.dataConnection
608602
$query = @"
609-
select memname, memtype, crdate, modate, nobs, nvar, compress,
603+
select memname, memtype, crdate, modate, nobs, nvar, compress,
610604
memlabel, typemem, filesize, delobs
611605
from sashelp.vtable
612606
where libname='$libname' and memname='$memname';

0 commit comments

Comments
 (0)