chore: disable recycle bin support for sas server

Author: Scott Dover

client/src/components/ContentNavigator/ContentDataProvider.ts

@@ -315,6 +315,10 @@ class ContentDataProvider
     return success;
   }
 
+  public canRecycleResource(item: ContentItem): boolean {
+    return this.model.canRecycleResource(item);
+  }
+
   public async recycleResource(item: ContentItem): Promise<boolean> {
     if (!(await closeFileIfOpen(item))) {
       return false;

client/src/components/ContentNavigator/ContentModel.ts

@@ -4,6 +4,7 @@ import { Uri } from "vscode";
 
 import { ALL_ROOT_FOLDERS, Messages } from "./const";
 import { ContentAdapter, ContentItem } from "./types";
+import { isItemInRecycleBin } from "./utils";
 
 export class ContentModel {
   private contentAdapter: ContentAdapter;
@@ -139,11 +140,20 @@ export class ContentModel {
     return await this.contentAdapter.getFolderPathForItem(contentItem);
   }
 
+  public canRecycleResource(item: ContentItem): boolean {
+    return (
+      this.contentAdapter.recycleItem &&
+      this.contentAdapter.restoreItem &&
+      !isItemInRecycleBin(item) &&
+      item.permission.write
+    );
+  }
+
   public async recycleResource(item: ContentItem) {
-    return await this.contentAdapter.recycleItem(item);
+    return await this.contentAdapter?.recycleItem(item);
   }
 
   public async restoreResource(item: ContentItem) {
-    return await this.contentAdapter.restoreItem(item);
+    return await this.contentAdapter?.restoreItem(item);
   }
 }

client/src/components/ContentNavigator/index.ts

@@ -29,7 +29,7 @@ import {
   ContentSourceType,
   FileManipulationEvent,
 } from "./types";
-import { isContainer as getIsContainer, isItemInRecycleBin } from "./utils";
+import { isContainer as getIsContainer } from "./utils";
 
 const fileValidator = (value: string): string | null =>
   /^([^/<>;\\{}?#]+)\.\w+$/.test(
@@ -93,7 +93,7 @@ class ContentNavigator implements SubscriptionProvider {
             async (resource: ContentItem) => {
               const isContainer = getIsContainer(resource);
               const moveToRecycleBin =
-                !isItemInRecycleBin(resource) && resource.permission.write;
+                this.contentDataProvider.canRecycleResource(resource);
               if (
                 !moveToRecycleBin &&
                 !(await window.showWarningMessage(

client/src/components/ContentNavigator/types.ts

@@ -90,13 +90,13 @@ export interface ContentAdapter {
     item: ContentItem,
     targetParentFolderUri: string,
   ) => Promise<boolean>;
-  recycleItem: (item: ContentItem) => Promise<{ newUri?: Uri; oldUri?: Uri }>;
+  recycleItem?: (item: ContentItem) => Promise<{ newUri?: Uri; oldUri?: Uri }>;
   removeItemFromFavorites: (item: ContentItem) => Promise<boolean>;
   renameItem: (
     item: ContentItem,
     newName: string,
   ) => Promise<ContentItem | undefined>;
-  restoreItem: (item: ContentItem) => Promise<boolean>;
+  restoreItem?: (item: ContentItem) => Promise<boolean>;
   updateContentOfItem(uri: Uri, content: string): Promise<void>;
 }
 

client/src/connection/rest/RestSASServerAdapter.ts

@@ -1,6 +1,5 @@
 // Copyright © 2024, SAS Institute Inc., Cary, NC, USA.  All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
-
 import { FileType, Uri } from "vscode";
 
 import { AxiosResponse } from "axios";
@@ -343,16 +342,6 @@ class RestSASServerAdapter implements ContentAdapter {
     return !!this.filePropertiesToContentItem(response.data);
   }
 
-  public async recycleItem(
-    item: ContentItem,
-  ): Promise<{ newUri?: Uri; oldUri?: Uri }> {
-    await this.deleteItem(item);
-    return {
-      newUri: getSasServerUri(item, true),
-      oldUri: getSasServerUri(item),
-    };
-  }
-
   public async removeItemFromFavorites(item: ContentItem): Promise<boolean> {
     throw new Error("Method not implemented.");
   }
@@ -379,10 +368,6 @@ class RestSASServerAdapter implements ContentAdapter {
     return this.filePropertiesToContentItem(response.data);
   }
 
-  public async restoreItem(item: ContentItem): Promise<boolean> {
-    throw new Error("Method not implemented.");
-  }
-
   public async updateContentOfItem(uri: Uri, content: string): Promise<void> {
     const filePath = this.trimComputePrefix(getResourceId(uri));
     return await this.updateContentOfItemAtPath(filePath, content);