Skip to content

Commit bc1d6cb

Browse files
Scott DoverScott Dover
authored andcommitted
chore: add comments for unimplemented code
1 parent 60454e5 commit bc1d6cb

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

client/src/components/ContentNavigator/types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ export interface ContentAdapter {
8181
getContentOfItem: (item: ContentItem) => Promise<string>;
8282
getContentOfUri: (uri: Uri) => Promise<string>;
8383
getFolderPathForItem: (item: ContentItem) => Promise<string>;
84-
getItemOfId: (id: string) => Promise<ContentItem>;
8584
getItemOfUri: (uri: Uri) => Promise<ContentItem>;
8685
getParentOfItem: (item: ContentItem) => Promise<ContentItem | undefined>;
8786
getRootFolder: (name: string) => ContentItem | undefined;

client/src/connection/rest/RestSASServerAdapter.ts

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class RestSASServerAdapter implements ContentAdapter {
8383
}
8484

8585
public connected(): boolean {
86-
// TODO
86+
// TODO (sas-server)
8787
return true;
8888
}
8989

@@ -243,12 +243,10 @@ class RestSASServerAdapter implements ContentAdapter {
243243
return response.data as unknown as string;
244244
}
245245

246-
public async getFolderPathForItem(item: ContentItem): Promise<string> {
247-
throw new Error("getFolderPathForItem Method not implemented.");
248-
}
249-
250-
public async getItemOfId(id: string): Promise<ContentItem> {
251-
throw new Error("getItemOfId Method not implemented.");
246+
public async getFolderPathForItem(): Promise<string> {
247+
// This is for creating a filename statement which won't work as expected for
248+
// file system files.
249+
return "";
252250
}
253251

254252
public async getItemOfUri(uri: Uri): Promise<ContentItem> {
@@ -266,11 +264,15 @@ class RestSASServerAdapter implements ContentAdapter {
266264
public async getParentOfItem(
267265
item: ContentItem,
268266
): Promise<ContentItem | undefined> {
267+
// TODO (sas-server) This is needed for converting a sas
268+
// notebook to flow.
269269
throw new Error("getParentOfItem Method not implemented.");
270270
}
271271

272-
public getRootFolder(name: string): ContentItem | undefined {
273-
throw new Error("getRootFolder Method not implemented.");
272+
public getRootFolder(): ContentItem | undefined {
273+
// TODO (sas-server) Re-implement this if SAS server supports
274+
// recycle bin
275+
return undefined;
274276
}
275277

276278
public async getRootItems(): Promise<RootFolderMap> {

0 commit comments

Comments
 (0)