fix: fix formatting for itc/validate sort

Signed-off-by: Scott Dover <[email protected]>

Author: Scott Dover

client/src/connection/itc/ItcLibraryAdapter.ts

@@ -185,9 +185,8 @@ class ItcLibraryAdapter implements LibraryAdapter {
     const sortString = sortModel
       .map((col) => `${col.colId} ${col.sort}`)
       .join(",");
-    const fullTableName = `${item.library}.${item.name}`;
     const code = `
-      $runner.GetDatasetRecords("${fullTableName}", ${start}, ${limit}, "${sortString}")
+      $runner.GetDatasetRecords("${item.library}","${item.name}", ${start}, ${limit}, "${sortString}")
     `;
     const output = await executeRawCode(code);
     try {

client/src/connection/itc/script.ts

@@ -244,21 +244,26 @@ class SASRunner{
     Write-Host "${LineCodes.ResultsFetchedCode}"
   }
 
-  [void]GetDatasetRecords([string]$tableName, [int]$start = 0, [int]$limit = 100, [string]$sortCriteria = "") {
+  [void]GetDatasetRecords([string]$library, [string]$table, [int]$start = 0, [int]$limit = 100, [string]$sortCriteria = "") {
     $objRecordSet = New-Object -comobject ADODB.Recordset
     $objRecordSet.ActiveConnection = $this.dataConnection # This is needed to set the properties for sas formats.
     $objRecordSet.Properties.Item("SAS Formats").Value = "_ALL_"
 
-    $query = "SELECT * FROM $tableName"
+    $tableName = $library + "." + $table
     if ($sortCriteria -ne "") {
-      $query = $query + " ORDER BY " + $sortCriteria
+      $epoch = [datetime]::FromFileTimeUtc(0)
+      $currentUtcTime = (Get-Date).ToUniversalTime()
+      $ts = [int64]($currentUtcTime - $epoch).TotalSeconds
+      $tableName = "WORK.temp_$ts"
+      $this.dataConnection.Execute("CREATE VIEW $tableName AS SELECT * FROM $library.$table ORDER BY $sortCriteria")
     }
+
     $objRecordSet.Open(
-      $query,
-      $this.dataConnection, # Use the active connection
-      3,  # adOpenStatic
+      $tableName,
+      [System.Reflection.Missing]::Value, # Use the active connection
+      2,  # adOpenDynamic
       1,  # adLockReadOnly
-      1   # adCmdText
+      512 # adCmdTableDirect
     )
 
     $records = [List[List[object]]]::new()
@@ -270,7 +275,6 @@ class SASRunner{
     }
 
     $objRecordSet.AbsolutePosition = $start + 1
-
     for ($j = 0; $j -lt $limit -and $objRecordSet.EOF -eq $False; $j++) {
       $cell = [List[object]]::new()
       for ($i = 0; $i -lt $fields; $i++) {
@@ -292,10 +296,14 @@ class SASRunner{
     $result | Add-Member -MemberType NoteProperty -Name "rows" -Value $records
     $result | Add-Member -MemberType NoteProperty -Name "count" -Value $count
 
+    if ($sortCriteria -ne "") {
+      $this.dataConnection.Execute("DROP VIEW $tableName")
+    }
+
     Write-Host $(ConvertTo-Json -Depth 10 -InputObject $result -Compress)
   }
 
-  [void]GetColumns([string]$libname, [string]$memname) {
+  [object[]] GetColumnData([string]$libname, [string]$memname) {
     $objRecordSet = New-Object -comobject ADODB.Recordset
     $objRecordSet.ActiveConnection = $this.dataConnection
     $query = @"
@@ -330,6 +338,12 @@ class SASRunner{
       $parsedRows += $parsedRow
     }
 
+    return $parsedRows
+  }
+
+  [void]GetColumns([string]$libname, [string]$memname) {
+    $parsedRows = $this.GetColumnData($libname, $memname)
+
     Write-Host $(ConvertTo-Json -Depth 10 -InputObject $parsedRows -Compress)
   }