chore: remove nock dependency (#1595)

**Summary**
Upgrading nock was leading to some strange errors around not being able to resolve the host. It
looks like we were only using it for one test, where it makes enough sense to mock the
compute api _instead_ of axios directly. 

**Testing**
 - [x] Made sure tests passed as expected

Author: scottdover

client/test/components/LibraryNavigator/LibraryDataProvider.test.ts

@@ -1,11 +1,13 @@
 import { TreeItemCollapsibleState, Uri, l10n } from "vscode";
 
+import { AxiosResponse } from "axios";
 import { expect } from "chai";
-import nock from "nock";
+import * as sinon from "sinon";
 
 import LibraryDataProvider from "../../../src/components/LibraryNavigator/LibraryDataProvider";
 import LibraryModel from "../../../src/components/LibraryNavigator/LibraryModel";
 import {
+  DefaultRecordLimit,
   Icons,
   Messages,
 } from "../../../src/components/LibraryNavigator/const";
@@ -15,23 +17,32 @@ import { DataAccessApi } from "../../../src/connection/rest/api/compute";
 import { getApiConfig } from "../../../src/connection/rest/common";
 
 class MockRestLibraryAdapter extends RestLibraryAdapter {
-  constructor() {
+  constructor(api: ReturnType<typeof DataAccessApi>) {
     super();
-    const apiConfig = getApiConfig();
-    apiConfig.baseOptions.baseURL = "http://test.local";
-    this.dataAccessApi = DataAccessApi(apiConfig);
+    this.dataAccessApi = api;
     this.sessionId = "1234";
   }
 }
 
 class MockLibraryModel extends LibraryModel {
-  constructor() {
-    super(new MockRestLibraryAdapter());
+  constructor(api: ReturnType<typeof DataAccessApi>) {
+    super(new MockRestLibraryAdapter(api));
   }
 }
 
-const libraryDataProvider = () =>
-  new LibraryDataProvider(new MockLibraryModel(), Uri.from({ scheme: "file" }));
+const dataAccessApi = () => {
+  const apiConfig = getApiConfig();
+  apiConfig.baseOptions.baseURL = "https://test.local";
+  return DataAccessApi(apiConfig);
+};
+
+const libraryDataProvider = (
+  api: ReturnType<typeof DataAccessApi> = dataAccessApi(),
+) =>
+  new LibraryDataProvider(
+    new MockLibraryModel(api),
+    Uri.from({ scheme: "file" }),
+  );
 
 describe("LibraryDataProvider", async function () {
   it("getChildren - returns an empty array when no adapter is specified", async () => {
@@ -53,19 +64,28 @@ describe("LibraryDataProvider", async function () {
       readOnly: false,
     };
 
-    nock("http://test.local")
-      .get("/sessions/1234/data/lib?start=0&limit=100")
-      .reply(200, {
-        items: [
-          {
-            id: "table",
-            name: "table",
-          },
-        ],
-        count: 0,
-      });
+    const api = dataAccessApi();
+    const getTablesStub = sinon.stub(api, "getTables");
+    getTablesStub
+      .withArgs({
+        sessionId: "1234",
+        libref: library.id,
+        limit: DefaultRecordLimit,
+        start: 0,
+      })
+      .resolves({
+        data: {
+          items: [
+            {
+              id: "table",
+              name: "table",
+            },
+          ],
+          count: 0,
+        },
+      } as AxiosResponse);
 
-    const provider = libraryDataProvider();
+    const provider = libraryDataProvider(api);
     const children = await provider.getChildren(library);
 
     expect(children[0]).to.deep.equal({
@@ -76,28 +96,34 @@ describe("LibraryDataProvider", async function () {
       type: "table",
       readOnly: library.readOnly,
     });
+    getTablesStub.restore();
   });
 
   it("getChildren - returns libraries without content item", async () => {
+    const api = dataAccessApi();
     // One call to get libraries
-    nock("http://test.local")
-      .get("/sessions/1234/data?start=0&limit=100")
-      .reply(200, {
+    const getLibrariesStub = sinon.stub(api, "getLibraries").resolves({
+      data: {
         items: [
           {
             id: "library",
             name: "library",
           },
         ],
         count: 0,
-      });
+      },
+    } as AxiosResponse);
 
-    // One to get
-    nock("http://test.local").get("/sessions/1234/data/library").reply(200, {
-      readOnly: true,
-    });
+    // One to get library summary
+    const getLibrarySummaryStub = sinon
+      .stub(api, "getLibrarySummary")
+      .resolves({
+        data: {
+          readOnly: true,
+        },
+      } as AxiosResponse);
 
-    const provider = libraryDataProvider();
+    const provider = libraryDataProvider(api);
     const children = await provider.getChildren();
 
     expect(children[0]).to.deep.equal({
@@ -108,6 +134,9 @@ describe("LibraryDataProvider", async function () {
       type: "library",
       readOnly: true,
     });
+
+    getLibrariesStub.restore();
+    getLibrarySummaryStub.restore();
   });
 
   it("getTreeItem - returns table tree item", async () => {
@@ -206,10 +235,13 @@ describe("LibraryDataProvider", async function () {
       library: "lib",
     };
 
-    nock("http://test.local").delete("/sessions/1234/data/lib/test").reply(200);
+    const api = dataAccessApi();
+    const deleteTableStub = sinon.stub(api, "deleteTable");
 
-    const provider = libraryDataProvider();
+    const provider = libraryDataProvider(api);
     await provider.deleteTable(item);
+    expect(deleteTableStub.calledOnce).to.equal(true);
+    deleteTableStub.restore();
   });
 
   it("deleteTable - fails with error message", async () => {
@@ -222,9 +254,11 @@ describe("LibraryDataProvider", async function () {
       library: "lib",
     };
 
-    nock("http://test.local").delete("/sessions/1234/data/lib/test").reply(500);
+    const api = dataAccessApi();
+    const deleteTableStub = sinon.stub(api, "deleteTable");
+    deleteTableStub.throwsException(new Error());
 
-    const provider = libraryDataProvider();
+    const provider = libraryDataProvider(api);
     try {
       await provider.deleteTable(item);
     } catch (error) {
@@ -233,5 +267,7 @@ describe("LibraryDataProvider", async function () {
           .message,
       );
     }
+
+    deleteTableStub.restore();
   });
 });

package-lock.json

@@ -1412,7 +1412,6 @@
     "eslint-plugin-react-hooks": "^5.2.0",
     "glob": "^7.2.0",
     "mocha": "^11.5.0",
-    "nock": "^13.5.5",
     "papaparse": "^5.5.3",
     "path-browserify": "^1.0.1",
     "prettier": "^3.5.3",