chore: add glob as devDependencies

Signed-off-by: Wei Wu <[email protected]>

Author: scnwwu

client/test/connection/itc/Coderunner.test.ts

@@ -3,54 +3,7 @@ import sinon from "sinon";
 
 import * as connection from "../../../src/connection";
 import { runCode } from "../../../src/connection/itc/CodeRunner";
-import { Session } from "../../../src/connection/session";
-
-export class MockSession extends Session {
-  private _logFn;
-  private _runMap: Record<string, string> | undefined;
-  public sasSystemLine = "The Sas System";
-
-  public set onSessionLogFn(logFn) {
-    this._logFn = logFn;
-  }
-  public set onExecutionLogFn(logFn) {
-    this._logFn = logFn;
-  }
-
-  public constructor(runMap?: Record<string, string>) {
-    super();
-    this._runMap = runMap;
-  }
-
-  protected async establishConnection(): Promise<void> {
-    return;
-  }
-
-  public async run(codeString: string): Promise<connection.RunResult> {
-    if (this._runMap) {
-      const [, result] = Object.entries(this._runMap).find(([code]) =>
-        codeString.includes(code),
-      );
-      if (result) {
-        this._logFn(
-          result.split("\n").map((line) => ({ line, type: "normal" })),
-        );
-        return;
-      }
-    }
-
-    this._logFn(
-      codeString.split("\n").map((line) => ({ line, type: "normal" })),
-    );
-    return {};
-  }
-
-  public close(): void | Promise<void> {}
-
-  public sessionId?(): string {
-    return "";
-  }
-}
+import { MockSession } from "../../utils";
 
 describe("CodeRunner tests", () => {
   let sessionStub;

client/test/connection/itc/ItcLibraryAdapter.test.ts

@@ -7,7 +7,7 @@ import {
 } from "../../../src/components/LibraryNavigator/types";
 import * as connection from "../../../src/connection";
 import ItcLibraryAdapter from "../../../src/connection/itc/ItcLibraryAdapter";
-import { MockSession } from "./Coderunner.test";
+import { MockSession } from "../../utils";
 
 const mockOutput = (now) => ({
   COLOUTPUT: `

client/test/index.ts

@@ -1,4 +1,4 @@
-import glob from "glob";
+import { glob } from "glob";
 import Mocha from "mocha";
 import path from "path";
 
@@ -17,27 +17,26 @@ export function run(): Promise<void> {
     : "**/**.test.js";
 
   return new Promise((resolve, reject) => {
-    glob(pattern, { cwd: testsRoot }, (err, files) => {
-      if (err) {
-        return reject(err);
-      }
+    glob(pattern, { cwd: testsRoot, windowsPathsNoEscape: true }).then(
+      (files) => {
+        // Add files to the test suite
+        files.forEach((f) => mocha.addFile(path.resolve(testsRoot, f)));
 
-      // Add files to the test suite
-      files.forEach((f) => mocha.addFile(path.resolve(testsRoot, f)));
-
-      try {
-        // Run the mocha test
-        mocha.run((failures) => {
-          if (failures > 0) {
-            reject(new Error(`${failures} tests failed.`));
-          } else {
-            resolve();
-          }
-        });
-      } catch (err) {
-        console.error(err);
-        reject(err);
-      }
-    });
+        try {
+          // Run the mocha test
+          mocha.run((failures) => {
+            if (failures > 0) {
+              reject(new Error(`${failures} tests failed.`));
+            } else {
+              resolve();
+            }
+          });
+        } catch (err) {
+          console.error(err);
+          reject(err);
+        }
+      },
+      reject,
+    );
   });
 }

client/test/utils.ts

@@ -4,6 +4,9 @@ import { assert } from "chai";
 import { readFileSync } from "fs";
 import * as path from "path";
 
+import type { RunResult } from "../src/connection";
+import { Session } from "../src/connection/session";
+
 export function getUri(name: string): vscode.Uri {
   return vscode.Uri.file(path.resolve(__dirname, "../../testFixture", name));
 }
@@ -43,3 +46,50 @@ export const assertThrowsAsync = async (fn, expectedMsg?: string) => {
   }
   assert.fail("function was expected to throw, but did not");
 };
+
+export class MockSession extends Session {
+  private _logFn;
+  private _runMap: Record<string, string> | undefined;
+  public sasSystemLine = "The Sas System";
+
+  public set onSessionLogFn(logFn) {
+    this._logFn = logFn;
+  }
+  public set onExecutionLogFn(logFn) {
+    this._logFn = logFn;
+  }
+
+  public constructor(runMap?: Record<string, string>) {
+    super();
+    this._runMap = runMap;
+  }
+
+  protected async establishConnection(): Promise<void> {
+    return;
+  }
+
+  public async run(codeString: string): Promise<RunResult> {
+    if (this._runMap) {
+      const [, result] = Object.entries(this._runMap).find(([code]) =>
+        codeString.includes(code),
+      );
+      if (result) {
+        this._logFn(
+          result.split("\n").map((line) => ({ line, type: "normal" })),
+        );
+        return;
+      }
+    }
+
+    this._logFn(
+      codeString.split("\n").map((line) => ({ line, type: "normal" })),
+    );
+    return {};
+  }
+
+  public close(): void | Promise<void> {}
+
+  public sessionId?(): string {
+    return "";
+  }
+}

package-lock.json

@@ -1119,6 +1119,7 @@
     "eslint": "^9.12.0",
     "eslint-plugin-react": "^7.37.1",
     "eslint-plugin-react-hooks": "^5.0.0",
+    "glob": "^11.0.0",
     "mocha": "^10.7.3",
     "nock": "^13.5.4",
     "papaparse": "^5.4.1",

package.json

@@ -1,5 +1,5 @@
 import { readFileSync, writeFileSync } from "fs";
-import glob from "glob";
+import { glob } from "glob";
 
 // These files will not be checked for copyright information
 const filesToIgnore = [

tools/check-copyright.mjs

@@ -1,5 +1,5 @@
 import { readFileSync, writeFileSync } from "fs";
-import glob from "glob";
+import { glob } from "glob";
 import csv from "papaparse";
 import { dirname, isAbsolute, join } from "path";
 import { fileURLToPath } from "url";