Skip to content

Commit e7ecac8

Browse files
authored
fix:deal with the question mark (#1533)
1 parent 40e6c52 commit e7ecac8

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

client/src/components/ContentNavigator/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ import {
3232
import { isContainer as getIsContainer } from "./utils";
3333

3434
const fileValidator = (value: string): string | null =>
35-
/^([^/<>;\\{}?]+)\.\w+$/.test(
36-
// file service does not allow /, <, >, ;, \, {, } while vscode does not allow ? and #
35+
/^([^/<>;\\{}]+)\.\w+$/.test(
36+
// file service does not allow /, <, >, ;, \, {, }
3737
value,
3838
)
3939
? null

client/src/connection/rest/util.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,18 @@ export const resourceType = (item: ContentItem): string | undefined => {
9898
export const getSasContentUri = (item: ContentItem, readOnly?: boolean): Uri =>
9999
Uri.parse(
100100
`${readOnly ? `${ContentSourceType.SASContent}ReadOnly` : ContentSourceType.SASContent}:/${
101-
item.name ? item.name.replace("#", "%23") : item.name
101+
item.name
102+
? item.name.replace(/#/g, "%23").replace(/\?/g, "%3F")
103+
: item.name
102104
}?id=${getResourceIdFromItem(item)}`,
103105
);
104106

105107
export const getSasServerUri = (item: ContentItem, readOnly?: boolean): Uri =>
106108
Uri.parse(
107109
`${readOnly ? `${ContentSourceType.SASServer}ReadOnly` : ContentSourceType.SASServer}:/${
108-
item.name ? item.name.replace("#", "%23") : item.name
110+
item.name
111+
? item.name.replace(/#/g, "%23").replace(/\?/g, "%3F")
112+
: item.name
109113
}?id=${getResourceIdFromItem(item)}`,
110114
);
111115

0 commit comments

Comments
 (0)