fix: should not clear log for non-user running #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wei Wu <[email protected]>
scnwwu
force-pushed
the
p-clearlogissue
branch
from
5f15bb8 to
ee13888
Compare
scottdover
approved these changes
Oct 25, 2024
ShermanWang0324
added
testing
Collaborator
|
Tested the fix with SAS9.4 connection, the log can persistent display on output window and no disappear. |
ShermanWang0324
approved these changes
Oct 29, 2024
ShermanWang0324
added
testing-complete
ShermanWang0324
added
ready for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1243
ITCLibraryAdapter internally runs SAS code. We should not clear log in this case.
Testing
Test case in #1243