feat: inherit VS Code file icons in SAS Content and Server #1310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottdover
approved these changes
Dec 6, 2024
| break; | ||
| } | ||
| } else { | ||
| const extension = item.name.split(".").pop().toLowerCase(); |
Contributor
There was a problem hiding this comment.
Am I understanding correctly? By removing this case, we return undefined, and package.json basically dictates the icon for .sas extension files, right? (looking at
vscode-sas-extension/package.json
Lines 1110 to 1113 in 95794c6
If this is accurate, this LGTM
tianliang657
added
testing-complete
tianliang657
approved these changes
Dec 9, 2024
tianliang657
left a comment
tianliang657
left a comment
There was a problem hiding this comment.
This issue is fixed in the playpen sas extension, no other issues were found, so approving.
tianliang657
added
ready for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1299
We should not explicitly specify a general file icon so that VS Code can go with its default.
It honors user's File Icon Themes
Testing
See file icons in SAS Content and SAS Server same to VS Code Explorer view.