Added feature to check for unsaved files in a folder upon deletion. #1559

kpatl1 · 2025-07-16T19:32:24Z

Summary
I have added a function that checks if there are unsaved files within a folder. If so, it will open a modal asking if the user wants to actually delete the folder. On deletion it will then move to recycle bin.
Testing
How did you test this change?
I followed the steps to recreate the feature request by joining a viya server, making a new folder with two unsaved files, and then try to delete the folder. After deleting it, I got the message if I truly did want to and then I had the option to continue or cancel. On continuation, the folder then moved to recycle bin.

Fixes #1136

…nsion into kibpat_VSExt_1136

…code-sas-extension into kibpat_VSExt_1136

I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: ae98ac4 I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 774bc8e I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 4b8f211 Signed-off-by: Kishan Patel <[email protected]>

client/src/connection/rest/SASContentAdapter.ts

…yer.

I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 877ec93 I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 1bf8187 Signed-off-by: Kishan Patel <[email protected]>

…nsion into kibpat_VSExt_1136

…code-sas-extension into kibpat_VSExt_1136

kpatl1 · 2025-07-23T20:47:37Z

Added fixes. Put the logic into the UI and Service layer. Children are found recursively for the folder and added to a set. Open files are then referenced into the set to see if they are within it. If the file is dirty and in the children set, a popup will appear. Overall, time complexity boils down to O(N + M) I believe where N is the number of files within a root directory and M being the number of files being open in the window.

client/src/components/ContentNavigator/ContentDataProvider.ts

I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 5ef4032 I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 3195f1d I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 9166f84 Signed-off-by: Kishan Patel <[email protected]>

scnwwu

@kpatl1, for your nested folder question, if you dump your uriToParentMap, you'll see that the Uri format in key and value are different.
I've added suggestions that will make it work

client/src/components/ContentNavigator/ContentDataProvider.ts

Co-authored-by: Wei Wu <[email protected]>

package-lock.json

client/src/components/ContentNavigator/index.ts

I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 5da1aa5 Signed-off-by: Kishan Patel <[email protected]> Signed-off-by: Kishan Patel <[email protected]>

I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 2c3e6e2 I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: ed1cf13 I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: b8dbf88 I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 0cba768 I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: d0c8028 Signed-off-by: Kishan Patel <[email protected]>

client/src/components/ContentNavigator/index.ts

client/src/components/ContentNavigator/ContentDataProvider.ts

Signed-off-by: Kishan Patel <[email protected]>

kpatl1

resolved comments, and tested functionality again.

client/src/components/ContentNavigator/ContentDataProvider.ts

Signed-off-by: Kishan Patel <[email protected]>

I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 5da1aa5 Signed-off-by: Kishan Patel <[email protected]>

Zhirong2022 · 2025-08-25T02:55:02Z

It has no further response if trying to delete the folder which contains unsaved file after switch to a new Viya profile.
Steps to reproduce:
Suppose having two valid Viya connection
1.Sign in with one of the Viya server
2.Go to SAS Server, create a new file under a specified personal file folder and kept it unsaved
3.Switch to another Viya server
4.Delete the specified file folder which contains the unsaved file

kpatl1 · 2025-08-25T17:14:50Z

It has no further response if trying to delete the folder which contains unsaved file after switch to a new Viya profile. Steps to reproduce: Suppose having two valid Viya connection 1.Sign in with one of the Viya server 2.Go to SAS Server, create a new file under a specified personal file folder and kept it unsaved 3.Switch to another Viya server 4.Delete the specified file folder which contains the unsaved file

I believe that is because VSCode will no longer mark the file as dirty since you are reloading the connection. I am unsure is there is a way to work around this as it is a base issue coming from VSCode no?

I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 7b7c95b I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 597cb50 Signed-off-by: Kishan Patel <[email protected]>

Kishan Patel added 2 commits July 8, 2025 13:41

Needs testing with live connection. But should fix error.

ae98ac4

added feature to check for unsaved files in folder

774bc8e

kpatl1 requested a review from scnwwu July 16, 2025 19:32

kpatl1 added the good first issue Good for newcomers label Jul 16, 2025

kpatl1 and others added 7 commits July 16, 2025 15:32

Merge branch 'main' into kibpat_VSExt_1136

18e96b2

Merge branch 'main' of https://github.com/sassoftware/vscode-sas-exte…

8edc365

…nsion into kibpat_VSExt_1136

Merge branch 'kibpat_VSExt_1136' of https://github.com/sassoftware/vs…

8faca94

…code-sas-extension into kibpat_VSExt_1136

undo changes on diff file

4b8f211

Update ContentDataProvider.ts

405d6e4

Update ContentDataProvider.ts

904a406

scnwwu removed the good first issue Good for newcomers label Jul 21, 2025

scnwwu reviewed Jul 21, 2025

View reviewed changes

client/src/connection/rest/SASContentAdapter.ts Outdated Show resolved Hide resolved

client/src/connection/rest/SASContentAdapter.ts Outdated Show resolved Hide resolved

kpatl1 added 6 commits July 22, 2025 17:18

testing a new fix within the UI and provider.

877ec93

removed code from SASContentAdapter and added it to UI and Service la…

1bf8187

…yer.

Merge branch 'main' into kibpat_VSExt_1136

30b81b7

Merge branch 'main' of https://github.com/sassoftware/vscode-sas-exte…

6593c67

…nsion into kibpat_VSExt_1136

Merge branch 'kibpat_VSExt_1136' of https://github.com/sassoftware/vs…

49edc94

…code-sas-extension into kibpat_VSExt_1136

scnwwu reviewed Jul 24, 2025

View reviewed changes

client/src/components/ContentNavigator/ContentDataProvider.ts Outdated Show resolved Hide resolved

kpatl1 added 5 commits July 24, 2025 13:54

changed to BFS with conccurrrent HTTP requests.

5ef4032

changes to reduce HTTP requests. needs fixing for depth > 1

3195f1d

needs upward traversal fix

9166f84

debug

5da1aa5

scnwwu reviewed Aug 11, 2025

View reviewed changes

client/src/components/ContentNavigator/ContentDataProvider.ts Outdated Show resolved Hide resolved

client/src/components/ContentNavigator/ContentDataProvider.ts Outdated Show resolved Hide resolved

client/src/components/ContentNavigator/ContentDataProvider.ts Outdated Show resolved Hide resolved

kpatl1 and others added 3 commits August 11, 2025 12:13

Update client/src/components/ContentNavigator/ContentDataProvider.ts

0d116e8

Co-authored-by: Wei Wu <[email protected]>

Update client/src/components/ContentNavigator/ContentDataProvider.ts

0bb9429

Co-authored-by: Wei Wu <[email protected]>

Update client/src/components/ContentNavigator/ContentDataProvider.ts

3d4cc59

Co-authored-by: Wei Wu <[email protected]>

kpatl1 and others added 3 commits August 11, 2025 12:30

Merge branch 'main' into kibpat_VSExt_1136

9ce3d05

prettier formatting.

b8dbf88

linting

0cba768

scnwwu reviewed Aug 12, 2025

View reviewed changes

package-lock.json Outdated Show resolved Hide resolved

client/src/components/ContentNavigator/index.ts Outdated Show resolved Hide resolved

client/src/components/ContentNavigator/index.ts Outdated Show resolved Hide resolved

scnwwu mentioned this pull request Aug 15, 2025

feat(ContentNavigator): added more detailed path information #1597

Open

Kishan Patel and others added 6 commits August 15, 2025 15:56

feat(ContentNavigator): resolved comments

e10ae07

Update index.ts

b35aae3

feat(ContentNavigator): remove changes from package lock

bfdc1a6

Merge branch 'main' into kibpat_VSExt_1136

d0c8028

DCO Remediation Commit for Kishan Patel <[email protected]>

123b7e6

I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 5da1aa5 Signed-off-by: Kishan Patel <[email protected]> Signed-off-by: Kishan Patel <[email protected]>

scnwwu reviewed Aug 19, 2025

View reviewed changes

feat(ContentNavigator): resolved comments

8bf29bd

Signed-off-by: Kishan Patel <[email protected]>

kpatl1 commented Aug 19, 2025

View reviewed changes

scnwwu reviewed Aug 20, 2025

View reviewed changes

client/src/components/ContentNavigator/ContentDataProvider.ts Outdated Show resolved Hide resolved

kpatl1 added 2 commits August 20, 2025 14:33

feat(ContentNavigator): fixed uriToParentMap logic

db699d4

Signed-off-by: Kishan Patel <[email protected]>

DCO Remediation Commit for Kishan Patel <[email protected]>

7999067

I, Kishan Patel <[email protected]>, hereby add my Signed-off-by to this commit: 5da1aa5 Signed-off-by: Kishan Patel <[email protected]>

scnwwu approved these changes Aug 21, 2025

View reviewed changes

scnwwu assigned enzhihpp Aug 21, 2025

scnwwu added the verification-needed label Aug 21, 2025

scnwwu added this to the 1.17.0 milestone Aug 21, 2025

enzhihpp assigned Zhirong2022 and unassigned enzhihpp Aug 21, 2025

Zhirong2022 added testing Test the pull requests and removed verification-needed labels Aug 21, 2025

kpatl1 added 3 commits August 26, 2025 14:49

feat(ContentNavigator): fixed while loop condition

7b7c95b

fix(ContentNavigator) added check for dirty notebooks

597cb50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added feature to check for unsaved files in a folder upon deletion. #1559

Added feature to check for unsaved files in a folder upon deletion. #1559

Uh oh!

kpatl1 commented Jul 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

kpatl1 commented Jul 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

scnwwu left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kpatl1 left a comment

Uh oh!

Uh oh!

Zhirong2022 commented Aug 25, 2025

Uh oh!

kpatl1 commented Aug 25, 2025

Uh oh!

Uh oh!

Added feature to check for unsaved files in a folder upon deletion. #1559

Are you sure you want to change the base?

Added feature to check for unsaved files in a folder upon deletion. #1559

Uh oh!

Conversation

kpatl1 commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kpatl1 commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

scnwwu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kpatl1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Zhirong2022 commented Aug 25, 2025

Uh oh!

kpatl1 commented Aug 25, 2025

Uh oh!

Uh oh!

kpatl1 commented Jul 16, 2025 •

edited

Loading

kpatl1 commented Jul 23, 2025 •

edited

Loading