fix: fix build process #1594
Merged
fix: fix build process #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Dover <[email protected]>
|
Hey @clangsmith . This should address the build issues you were seeing last week. Let me know if this doesn't resolve things |
Maybe I spoke to soon. I'll address these build failures and get this up/ready to test soon. |
Signed-off-by: Scott Dover <[email protected]>
scnwwu
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@clangsmith noticed that the build process was not working as expected when following instructions here: https://github.com/sassoftware/vscode-sas-extension/blob/main/CONTRIBUTING.md#get-started.
This updates our process to copy files as part of rebuild, and cleanup files when starting build scripts (to make sure we're not holding on to any stale assets)
Testing
npm run vscode:prepublishmultiple times to make sure things worked (after removing dist files)Launch clientfollowed bynpm run vscode:prepublishto make sure nothing was broken