Skip to content

feat(LanguageServiceProvider): added code comment collapsing #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(LanguageServiceProvider): added code comment collapsing #1638

wants to merge 5 commits into from

Conversation

kpatl1
Copy link
Collaborator

@kpatl1 kpatl1 commented Sep 15, 2025

Summary
Added multiline comment folding support for SAS files. Users can now collapse/expand multiline comment blocks (/* ... */) using folding arrows in the editor margin, matching the existing folding behavior for data steps and procs.

Testing

  • Created test file with various multiline comment scenarios (standalone comments, comments within code blocks)
  • Verified folding arrows appear for multiline comments spanning multiple lines
  • Confirmed single-line comments do not show folding arrows (expected behavior)
  • Tested in Extension Development Host to ensure functionality works correctly
  • Validated that existing code block folding (data steps, procs) remains unaffected

Fixes #1579

@kpatl1 kpatl1 requested review from scottdover and scnwwu September 15, 2025 19:51
@kpatl1 kpatl1 marked this pull request as ready for review September 15, 2025 19:55
scnwwu
scnwwu reviewed Sep 17, 2025
View reviewed changes
Copy link
Member

@scnwwu scnwwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess all comment tokens will go through this function
https://github.com/sassoftware/vscode-sas-extension/blob/main/server/src/sas/SyntaxProvider.ts#L254
SyntaxProvider can collect all multiline comments and provide an API for consumers to get.

@scnwwu
Copy link
Member

scnwwu commented Sep 18, 2025

I guess all comment tokens will go through this function https://github.com/sassoftware/vscode-sas-extension/blob/main/server/src/sas/SyntaxProvider.ts#L254 SyntaxProvider can collect all multiline comments and provide an API for consumers to get.

Hi @kpatl1, have you seen my comment above? I guess it can be a uniform way to collect all comment tokens.

scnwwu
scnwwu reviewed Sep 19, 2025
View reviewed changes
Copy link
Member

@scnwwu scnwwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good to me. Thanks!

@scnwwu scnwwu added this to the 1.18.0 milestone Sep 25, 2025
@enzhihpp enzhihpp assigned Zhirong2022 and unassigned enzhihpp Sep 25, 2025
@Zhirong2022 Zhirong2022 added testing Test the pull requests and removed verification-needed labels Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scnwwu scnwwu scnwwu approved these changes

@scottdover scottdover Awaiting requested review from scottdover

Assignees

@Zhirong2022 Zhirong2022

Labels
testing Test the pull requests
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

Collapsing Comment Blocks
4 participants
@kpatl1 @scnwwu @enzhihpp @Zhirong2022