Skip to content

Conversation

@scottdover
Copy link
Contributor

Summary
This adds a new item to the pull request template, reminding users to update changelogs and
update documentation for changes

@scottdover scottdover marked this pull request as ready for review September 17, 2025 17:22
@scnwwu
Copy link
Contributor

scnwwu commented Sep 18, 2025

I guess we talked about CHANGELOG previously. A concern is that we usually have multiple PRs ongoing and it will cause merge conflicts when they all change CHANGELOG. I do finallize the CHANGELOG upon release based on the milestone record. So I guess CHANGELOG is optional.

@scottdover
Copy link
Contributor Author

I guess we talked about CHANGELOG previously. A concern is that we usually have multiple PRs ongoing and it will cause merge conflicts when they all change CHANGELOG. I do finallize the CHANGELOG upon release based on the milestone record. So I guess CHANGELOG is optional.

Makes sense. Updated the message accordingly :)

@scottdover scottdover merged commit fe27250 into main Sep 29, 2025
2 checks passed
@scottdover scottdover deleted the scottdover-patch-1 branch September 29, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants