Should onIndexChange be required if swipeEnabled is false and renderTabBar returns null?

[buschco]

Question

I am wondering if it is safe to pass an empty function (or even null) to onIndexChange? I manage the state in the Components state as you can see here:

const views = { screenA: 0, screenB: 1 };

function Example() {
  const [edit, setEdit] = React.useState(null);

 return (
  <TabView
    renderTabBar={() => null} // no tab bar
    onIndexChange={() => {}} // <- is this safe?
    swipeEnabled={false} // disable swipe
    lazy
    navigationState={{
      index: views[edit != null ? 'screenA' : 'screenB'],
      routes: Object.keys(views).map(key => ({ key })),
    }}
    renderScene={SceneMap({
      screenA: () => (
        <TouchableOpacity
          onPress={() => setEdit( { name: 'enter name' } )}
        >
          <Text>Edit Name</Text>
        </TouchableOpacity>
      ),
      screenB: () => (
        <TouchableOpacity
          onPress={() => setEdit( null )}
        >
          <Text>Finish editing</Text>
        </TouchableOpacity>
      )
    })}
  />
)}

Versions

[email protected]
[email protected]
[email protected]
[email protected]

[github-actions[bot]]

Couldn't find version numbers for the following packages in the issue:

• react-native
• react-native-tab-view
• react-native-gesture-handler
• react-native-reanimated

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

[satya164]

onIndexChange will still be needed if someone calls jumpTo - the prop is passed to the screens in SceneMap