Skip to content

Commit 756ce62

Browse files
authored
fix: standardize error handling across modules
* Standardize error handling across modules - Replace unsafe (error as Error).message casts with proper instanceof checks in pdf and image parsers - Remove new Promise(async ...) anti-pattern in MLCEngineWrapper.clearModelCache - Fix error message in MLC loadModel that stringified entire config object instead of using modelConfig.modelName Fixes #247 * style: fix Prettier formatting in parser files
1 parent 6fdbf34 commit 756ce62

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/core/parsers/image.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ export class ImageParser {
137137
debugInfo: options.debug ? debugInfo : undefined,
138138
};
139139
} catch (error) {
140-
const errorMessage = (error as Error).message;
140+
const errorMessage = error instanceof Error ? error.message : String(error);
141141
if (options.debug) debugInfo.push(`Error: ${errorMessage}`);
142142

143143
return {

src/core/parsers/pdf.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ export class PDFParser {
154154

155155
return this.extractTextFromPdf(pdf, options, debugInfo);
156156
} catch (error) {
157-
const errorMessage = (error as Error).message;
157+
const errorMessage = error instanceof Error ? error.message : String(error);
158158
if (options.debug) debugInfo.push(`Error: ${errorMessage}`);
159159
console.error('PDF parsing error:', error);
160160

@@ -210,7 +210,7 @@ export class PDFParser {
210210
throw loadError;
211211
}
212212
} catch (error) {
213-
const errorMessage = (error as Error).message;
213+
const errorMessage = error instanceof Error ? error.message : String(error);
214214
if (options.debug) debugInfo.push(`Error: ${errorMessage}`);
215215
console.error('PDF parsing error:', error);
216216

@@ -259,7 +259,7 @@ export class PDFParser {
259259

260260
pageTexts.push(pageText);
261261
} catch (error) {
262-
errors.push(`Error extracting text from page ${i}: ${(error as Error).message}`);
262+
errors.push(`Error extracting text from page ${i}: ${error instanceof Error ? error.message : String(error)}`);
263263
}
264264
}
265265

src/engines/mlc-engine-wrapper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ export class MLCEngineWrapper {
582582
this.worker = null;
583583
}
584584
const message = error instanceof Error ? error.message : String(error);
585-
throw new Error(`Failed to load MLC model "${modelConfig}": ${message}`);
585+
throw new Error(`Failed to load MLC model "${modelConfig.modelName}": ${message}`);
586586
}
587587
}
588588

0 commit comments

Comments
 (0)