updates ruff rules

Author: saxix

pyproject.toml

@@ -85,23 +85,34 @@ lint.select = [
   "ALL",
 ]
 lint.ignore = [
-  "ANN401", #  Dynamically typed expressions
+  "A",
+  "ANN",
+  "ARG", # Unused function argument:
+  "B",
+  "BLE",
   "COM812",
   "CPY",    # Missing copyright notice
   "D",      # docstring
   "DOC",    # docstring
-  "E731",   #  Do not assign a `lambda` expression,
-  "EM101",  #  Exception must not use a string literal, assign to variable first
-  "EM102",  #  Exception must not use a f-string literal, assign to variable first
-  "FBT001", #  Boolean-typed positional argument in function definition
-  "FBT002", #  Boolean default positional argument in function definition
-  "N806",   # Variable `...` in function should be lowercase
-  "S308",   # Use of `mark_safe` may expose cross-site scripting vulnerabilities
-  "SLF001", #  Private member accessed: `...`
-  "TRY003", # Avoid specifying long messages outside the exception class
-  "TRY301", # Abstract `raise` to an inner function
-  "TRY401", #  Redundant exception object included in `logging.exception` call
-  "UP037",  #
+  "EM",
+  "EXE",
+  "ERA",
+  "FBT",
+  "G",
+  "N",
+  "PERF",
+  "PLC",
+  "PLR",
+  "PLW",
+  "PGH",
+  "PT",
+  "RUF",
+  "S",
+  "SIM",
+  "SLF",
+  "TRY",
+  "UP",
+
 ]
 lint.per-file-ignores."docs/conf.py" = [
   "A001",   #

src/concurrency/admin.py

@@ -125,9 +125,7 @@ def response_action(self, request, queryset):  # noqa
                                 "A tuple with `primary_key, version_number` "
                                 f"expected:  `{x}` found"
                             )
-                            raise ImproperlyConfigured(
-                                msg
-                            )
+                            raise ImproperlyConfigured(msg)
                         filters.append(Q(**{"pk": pk, revision_field.attname: version}))
 
                     queryset = queryset.filter(reduce(operator.or_, filters))

src/concurrency/config.py

@@ -64,12 +64,8 @@ def _set_attr(self, prefix_name, value) -> None:
             elif callable(value):
                 func = value
             else:
-                msg = (
-                    f"{value} is not a valid value for `CALLBACK`. It must be a callable or a fullpath to callable. "
-                )
-                raise ImproperlyConfigured(
-                    msg
-                )
+                msg = f"{value} is not a valid value for `CALLBACK`. It must be a callable or a fullpath to callable. "
+                raise ImproperlyConfigured(msg)
             self._callback = func
         elif name == "TRIGGERS_FACTORY":
             original = dict(value)

src/concurrency/triggers.py

@@ -128,14 +128,10 @@ def create(self, field) -> None:
             try:
                 self.connection.cursor().execute(stm)
             except BaseException as exc:  # pragma: no cover
-                msg = (
-                    f"""Error executing:
+                msg = f"""Error executing:
 {stm}
 {exc}"""
-                )
-                raise DatabaseError(
-                    msg
-                )
+                raise DatabaseError(msg)
         else:  # pragma: no cover
             pass
         field._trigger_exists = True

src/concurrency/utils.py

@@ -78,7 +78,7 @@ def test_concurrency_conflict(self) -> None:
         target_copy = self._get_concurrency_target()
         v1 = api.get_revision_of_object(target)
         v2 = api.get_revision_of_object(target_copy)
-        assert v1 == v2, f"got same row with different version ({v1}/{v2})"
+        assert v1 == v2, f"got same row with different version ({v1}/{v2})"  # noqa: S101
         target.save()
         assert target.pk is not None  # sanity check
         self.assertRaises(RecordModifiedError, target_copy.save)
@@ -88,15 +88,15 @@ def test_concurrency_safety(self) -> None:
 
         target = self.concurrency_model()
         version = api.get_revision_of_object(target)
-        assert not bool(version), f"version is not null {version}"
+        assert not bool(version), f"version is not null {version}"  # noqa: S101
 
     def test_concurrency_management(self) -> None:
         target = self.concurrency_model
-        assert hasattr(target, "_concurrencymeta"), f"{self.concurrency_model} is not under concurrency management"
+        assert hasattr(target, "_concurrencymeta"), f"{self.concurrency_model} is not under concurrency management"  # noqa: S101
 
         revision_field = target._concurrencymeta.field
 
-        assert revision_field in target._meta.fields, f"{self.concurrency_model}: version field not in meta.fields"
+        assert revision_field in target._meta.fields, f"{self.concurrency_model}: version field not in meta.fields"  # noqa: S101
 
 
 class ConcurrencyAdminTestMixin:
@@ -153,15 +153,6 @@ def fqn(o):
     """
     parts = []
 
-    # if inspect.ismethod(o):
-    #     try:
-    #         cls = o.im_class
-    #     except AttributeError:
-    #         # Python 3 eliminates im_class, substitutes __module__ and
-    #         # __qualname__ to provide similar information.
-    #         parts = (o.__module__, o.__qualname__)
-    #     else:
-    #         parts = (fqn(cls), get_classname(o))
     if hasattr(o, "__module__"):
         parts.extend((o.__module__, get_classname(o)))
     elif inspect.ismodule(o):