Detect accessing static property as non static

Author: jnoordsij

src/Rules/Properties/AccessPropertiesCheck.php

@@ -160,6 +160,16 @@ private function processSingleProperty(Scope $scope, PropertyFetch $node, string
 		}
 
 		$propertyReflection = $type->getProperty($name, $scope);
+		if ($propertyReflection->isStatic()) {
+			return [
+				RuleErrorBuilder::message(sprintf(
+					'Non-static access to static property %s::$%s.',
+					$propertyReflection->getDeclaringClass()->getDisplayName(),
+					$name,
+				))->identifier('staticProperty.nonStaticAccess')->build(),
+			];
+		}
+
 		if ($write) {
 			if ($scope->canWriteProperty($propertyReflection)) {
 				return [];

tests/PHPStan/Rules/Properties/AccessPropertiesRuleTest.php

@@ -344,6 +344,17 @@ public function testAccessPropertiesOnThisOnly(): void
 		);
 	}
 
+	public function testBug12692(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkUnionTypes = false;
+		$this->checkDynamicProperties = false;
+		$this->analyse([__DIR__ . '/data/bug-12692.php'], [[
+			'Non-static access to static property Bug12692\Foo::$static.',
+			14,
+		]]);
+	}
+
 	public function testAccessPropertiesAfterIsNullInBooleanOr(): void
 	{
 		$this->checkThisOnly = false;

tests/PHPStan/Rules/Properties/data/bug-12692.php

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Bug12692;
+
+class Foo
+{
+
+	public static $static;
+
+	public function foo()
+	{
+		$this->static;
+	}
+
+}