Skip to content

Commit ddb022f

Browse files
authored
Merge pull request #3 from Nordstrom/pr/upgrage-to-byte-buddy-1.7.9
Upgrade to Byte Buddy 1.7.8; remove lifecycle mapping plugin
2 parents 3a21fc7 + 653f3f8 commit ddb022f

File tree

2 files changed

+2
-59
lines changed

2 files changed

+2
-59
lines changed

README.md

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -84,38 +84,6 @@ Extended support for the method interception feature of **JUnit Foundation** is
8484
###### pom.xml
8585
```xml
8686
<build>
87-
<pluginManagement>
88-
<plugins>
89-
...
90-
<plugin>
91-
<groupId>org.eclipse.m2e</groupId>
92-
<artifactId>lifecycle-mapping</artifactId>
93-
<version>1.0.0</version>
94-
<configuration>
95-
<lifecycleMappingMetadata>
96-
<pluginExecutions>
97-
<pluginExecution>
98-
<pluginExecutionFilter>
99-
<groupId>net.bytebuddy</groupId>
100-
<artifactId>byte-buddy-maven-plugin</artifactId>
101-
<versionRange>[1.0.0,)</versionRange>
102-
<goals>
103-
<goal>transform</goal>
104-
<goal>transform-test</goal>
105-
</goals>
106-
</pluginExecutionFilter>
107-
<action>
108-
<execute />
109-
</action>
110-
</pluginExecution>
111-
</pluginExecutions>
112-
</lifecycleMappingMetadata>
113-
</configuration>
114-
</plugin>
115-
...
116-
</plugins>
117-
</pluginManagement>
118-
11987
<plugins>
12088
...
12189
<plugin>
@@ -143,7 +111,7 @@ Extended support for the method interception feature of **JUnit Foundation** is
143111

144112
```
145113

146-
The `byte-buddy-maven-plugin` element informs Maven to execute the `transform-test` goal using the transformation specified by **HookInstallingPlugin**. The `lifecycle-mapping` element informs **M2Eclipse** that it should execute the `transform-test` goal as well. This avoids the dreaded `Plugin execution not covered by lifecycle configuration` error. With these POM changes in place, method invocation hooks will be installed during the `process-test-classes` phase of the build:
114+
The `byte-buddy-maven-plugin` element informs Maven to execute the `transform-test` goal using the transformation specified by **HookInstallingPlugin**. With this POM change in place, method invocation hooks will be installed during the `process-test-classes` phase of the build:
147115

148116
###### Implementing MethodWatcher
149117
```java

pom.xml

Lines changed: 1 addition & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,14 @@
2727

2828
<properties>
2929
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
30-
<lifecycle-mapping.version>1.0.0</lifecycle-mapping.version>
3130
<java-utils.version>1.3.3</java-utils.version>
3231
<surefire-plugin.version>2.19.1</surefire-plugin.version>
3332
<compiler-plugin.version>3.6.0</compiler-plugin.version>
3433
<source-plugin.version>3.0.1</source-plugin.version>
3534
<javadoc-plugin.version>2.10.4</javadoc-plugin.version>
3635
<settings.version>2.0.7</settings.version>
3736
<junit.version>4.12</junit.version>
38-
<bytebuddy.version>1.7.5</bytebuddy.version>
37+
<bytebuddy.version>1.7.8</bytebuddy.version>
3938
<logback.version>1.2.2</logback.version>
4039
<gpg-plugin.version>1.6</gpg-plugin.version>
4140
<staging-plugin.version>1.6.7</staging-plugin.version>
@@ -125,30 +124,6 @@
125124
<target>1.8</target>
126125
</configuration>
127126
</plugin>
128-
<plugin>
129-
<groupId>org.eclipse.m2e</groupId>
130-
<artifactId>lifecycle-mapping</artifactId>
131-
<version>${lifecycle-mapping.version}</version>
132-
<configuration>
133-
<lifecycleMappingMetadata>
134-
<pluginExecutions>
135-
<pluginExecution>
136-
<pluginExecutionFilter>
137-
<groupId>net.bytebuddy</groupId>
138-
<artifactId>byte-buddy-maven-plugin</artifactId>
139-
<versionRange>[1.0.0,)</versionRange>
140-
<goals>
141-
<goal>transform-test</goal>
142-
</goals>
143-
</pluginExecutionFilter>
144-
<action>
145-
<execute />
146-
</action>
147-
</pluginExecution>
148-
</pluginExecutions>
149-
</lifecycleMappingMetadata>
150-
</configuration>
151-
</plugin>
152127
<plugin>
153128
<groupId>net.bytebuddy</groupId>
154129
<artifactId>byte-buddy-maven-plugin</artifactId>

0 commit comments

Comments
 (0)