Skip to content

Commit e7fd730

Browse files
committed
Fix Java 8 build break
1 parent df179fd commit e7fd730

File tree

4 files changed

+21
-11
lines changed

4 files changed

+21
-11
lines changed

src/main/java/com/nordstrom/automation/selenium/core/GridUtility.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.nordstrom.automation.selenium.core;
22

3+
import static java.nio.charset.StandardCharsets.UTF_8;
4+
35
import java.io.ByteArrayOutputStream;
46
import java.io.File;
57
import java.io.IOException;
@@ -13,7 +15,6 @@
1315
import java.net.URISyntaxException;
1416
import java.net.URL;
1517
import java.net.UnknownHostException;
16-
import java.nio.charset.StandardCharsets;
1718
import java.nio.file.Files;
1819
import java.nio.file.Path;
1920
import java.nio.file.Paths;
@@ -207,7 +208,7 @@ public static String readAvailable(InputStream inputStream) throws IOException {
207208
length = inputStream.read(buffer);
208209
result.write(buffer, 0, length);
209210
}
210-
return result.toString(StandardCharsets.UTF_8.name());
211+
return result.toString(UTF_8.name());
211212
}
212213

213214
/**

src/main/java/com/nordstrom/automation/selenium/plugins/AndroidActivityLauncher.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
11
package com.nordstrom.automation.selenium.plugins;
22

3+
import static java.nio.charset.StandardCharsets.UTF_8;
4+
35
import org.openqa.selenium.HasCapabilities;
46
import org.openqa.selenium.JavascriptExecutor;
57
import org.openqa.selenium.WebDriver;
68

9+
import com.nordstrom.common.base.UncheckedThrow;
10+
11+
import java.io.UnsupportedEncodingException;
712
import java.net.URI;
813
import java.net.URLDecoder;
9-
import java.nio.charset.StandardCharsets;
1014
import java.util.ArrayList;
1115
import java.util.Collections;
1216
import java.util.HashMap;
@@ -106,8 +110,12 @@ private static Map<String, List<String>> parseQueryParams(final URI uri) {
106110
int idx = pair.indexOf('=');
107111
String key = idx > 0 ? pair.substring(0, idx) : pair;
108112
String value = idx > 0 && pair.length() > idx + 1 ? pair.substring(idx + 1) : "";
109-
key = URLDecoder.decode(key, StandardCharsets.UTF_8);
110-
value = URLDecoder.decode(value, StandardCharsets.UTF_8);
113+
try {
114+
key = URLDecoder.decode(key, UTF_8.name());
115+
value = URLDecoder.decode(value, UTF_8.name());
116+
} catch (UnsupportedEncodingException e) {
117+
throw UncheckedThrow.throwUnchecked(e);
118+
}
111119
rawParams.computeIfAbsent(key, k -> new ArrayList<>()).add(value);
112120
}
113121

src/selenium3/java/com/nordstrom/automation/selenium/SeleniumConfig.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
package com.nordstrom.automation.selenium;
22

3+
import static java.nio.charset.StandardCharsets.UTF_8;
4+
35
import java.io.BufferedOutputStream;
46
import java.io.File;
57
import java.io.FileOutputStream;
68
import java.io.IOException;
79
import java.io.OutputStream;
810
import java.io.StringReader;
911
import java.net.URL;
10-
import java.nio.charset.StandardCharsets;
1112
import java.nio.file.Path;
1213
import java.nio.file.Paths;
1314
import java.util.Arrays;
@@ -262,7 +263,7 @@ public Path createHubConfig() throws IOException {
262263
hubConfig.servlets = Arrays.asList(servlets.toArray(new String[0]));
263264
try(OutputStream fos = new FileOutputStream(filePath.toFile());
264265
OutputStream out = new BufferedOutputStream(fos)) {
265-
out.write(new Json().toJson(hubConfig).getBytes(StandardCharsets.UTF_8));
266+
out.write(new Json().toJson(hubConfig).getBytes(UTF_8));
266267
}
267268
}
268269
return filePath;
@@ -307,7 +308,7 @@ public Path createNodeConfig(String capabilities, URL hubUrl) throws IOException
307308
nodeConfig.servlets = Arrays.asList(servlets.toArray(new String[0]));
308309
try(OutputStream fos = new FileOutputStream(filePath.toFile());
309310
OutputStream out = new BufferedOutputStream(fos)) {
310-
out.write(new Json().toJson(nodeConfig).getBytes(StandardCharsets.UTF_8));
311+
out.write(new Json().toJson(nodeConfig).getBytes(UTF_8));
311312
}
312313
}
313314
return filePath;

src/selenium4/java/com/nordstrom/automation/selenium/SeleniumConfig.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.nordstrom.automation.selenium;
22

3+
import static java.nio.charset.StandardCharsets.UTF_8;
34
import static org.openqa.selenium.json.Json.LIST_OF_MAPS_TYPE;
45
import static org.openqa.selenium.json.Json.MAP_TYPE;
56

@@ -10,7 +11,6 @@
1011
import java.io.OutputStream;
1112
import java.io.Reader;
1213
import java.net.URL;
13-
import java.nio.charset.StandardCharsets;
1414
import java.nio.file.Files;
1515
import java.nio.file.Path;
1616
import java.nio.file.Paths;
@@ -422,7 +422,7 @@ public Path createHubConfig() throws IOException {
422422
distributorOptions.put("slot-matcher", slotMatcher);
423423
try (OutputStream fos = new FileOutputStream(filePath.toFile());
424424
OutputStream out = new BufferedOutputStream(fos)) {
425-
out.write(new Json().toJson(hubConfig).getBytes(StandardCharsets.UTF_8));
425+
out.write(new Json().toJson(hubConfig).getBytes(UTF_8));
426426
}
427427
}
428428
return filePath;
@@ -505,7 +505,7 @@ public Path createNodeConfig(String capabilities, URL hubUrl) throws IOException
505505
}
506506
try (OutputStream fos = new FileOutputStream(filePath.toFile());
507507
OutputStream out = new BufferedOutputStream(fos)) {
508-
out.write(new Json().toJson(nodeConfig).getBytes(StandardCharsets.UTF_8));
508+
out.write(new Json().toJson(nodeConfig).getBytes(UTF_8));
509509
}
510510
}
511511
return filePath;

0 commit comments

Comments
 (0)