1515# specific language governing permissions and limitations
1616# under the License.
1717import typing
18+ import warnings
1819
1920from selenium .webdriver .common import service
2021
@@ -28,7 +29,7 @@ class Service(service.Service):
2829 :param executable_path: install path of the WebKitWebDriver executable, defaults to `WebKitWebDriver`.
2930 :param port: Port for the service to run on, defaults to 0 where the operating system will decide.
3031 :param service_args: (Optional) List of args to be passed to the subprocess when launching the executable.
31- :param log_path : (Optional) File path for the file to be opened and passed as the subprocess stdout/stderr handler.
32+ :param log_output : (Optional) File path for the file to be opened and passed as the subprocess stdout/stderr handler.
3233 :param env: (Optional) Mapping of environment variables for the new process, defaults to `os.environ`.
3334 """
3435
@@ -37,16 +38,20 @@ def __init__(
3738 executable_path : str = DEFAULT_EXECUTABLE_PATH ,
3839 port : int = 0 ,
3940 log_path : typing .Optional [str ] = None ,
41+ log_output : typing .Optional [str ] = None ,
4042 service_args : typing .Optional [typing .List [str ]] = None ,
4143 env : typing .Optional [typing .Mapping [str , str ]] = None ,
4244 ** kwargs ,
4345 ) -> None :
4446 self .service_args = service_args or []
45- log_file = open (log_path , "wb" ) if log_path else None
47+ if log_path is not None :
48+ warnings .warn ("log_path is deprecated, use log_output instead" , DeprecationWarning , stacklevel = 2 )
49+ log_path = open (log_path , "wb" )
50+ log_output = open (log_output , "wb" ) if log_output else None
4651 super ().__init__ (
4752 executable_path = executable_path ,
4853 port = port ,
49- log_file = log_file ,
54+ log_output = log_path or log_output ,
5055 env = env ,
5156 ** kwargs ,
5257 )
0 commit comments