Skip to content

Commit 2028147

Browse files
committed
fix(menu): ensure selectedIdentifier validation before updating the action state
- Add check to validate selectedIdentifier is not an empty string before comparison - Update Podfile.lock to reflect dependency changes
1 parent d1b9893 commit 2028147

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

example/ios/Podfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2609,7 +2609,7 @@ SPEC CHECKSUMS:
26092609
fmt: a40bb5bd0294ea969aaaba240a927bd33d878cdd
26102610
glog: 5683914934d5b6e4240e497e0f4a3b42d1854183
26112611
hermes-engine: 4f8246b1f6d79f625e0d99472d1f3a71da4d28ca
2612-
Menu: 07807d3624231a1fcb047f697d48f10b99a31fbc
2612+
Menu: 3323e9fd0c9490b3c34a8cb563a5de9bc33df0de
26132613
RCT-Folly: 846fda9475e61ec7bcbf8a3fe81edfcaeb090669
26142614
RCTDeprecation: c4b9e2fd0ab200e3af72b013ed6113187c607077
26152615
RCTRequired: e97dd5dafc1db8094e63bc5031e0371f092ae92a
@@ -2672,7 +2672,7 @@ SPEC CHECKSUMS:
26722672
React-timing: 97ada2c47b4c5932e7f773c7d239c52b90d6ca68
26732673
React-utils: f0949d247a46b4c09f03e5a3cb1167602d0b729a
26742674
ReactAppDependencyProvider: 3eb9096cb139eb433965693bbe541d96eb3d3ec9
2675-
ReactCodegen: 4d203eddf6f977caa324640a20f92e70408d648b
2675+
ReactCodegen: 361a5bdffb9e344011158a8ec041a85db6381893
26762676
ReactCommon: ce5d4226dfaf9d5dacbef57b4528819e39d3a120
26772677
SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
26782678
Yoga: 11c9686a21e2cd82a094a723649d9f4507200fb0

ios/MenuView.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ - (void)updateMenuItems:(NSArray<NSDictionary *> *)menuItems selectedIdentifier:
204204
}];
205205

206206
// Set state based on current selection (controlled via props)
207-
if (selectedIdentifier != nil && [identifier isEqualToString:selectedIdentifier]) {
207+
if (selectedIdentifier != nil && ![selectedIdentifier isEqualToString:@""] && [identifier isEqualToString:selectedIdentifier]) {
208208
action.state = UIMenuElementStateOn;
209209
}
210210

0 commit comments

Comments
 (0)