Remove unused internal setting: BULK_MEMORY. NFC

It looks like the last usage of this setting was removed in emscripten-core#22873.

Author: sbc100

emcc.py

@@ -44,6 +44,7 @@
 from tools.response_file import substitute_response_files
 from tools import config
 from tools import cache
+from tools import feature_matrix
 from tools.settings import default_setting, user_settings, settings, COMPILE_TIME_SETTINGS
 from tools.utils import read_file
 
@@ -432,7 +433,7 @@ def phase_setup(options, state):
     settings.SHARED_MEMORY = 1
 
   if settings.SHARED_MEMORY:
-    settings.BULK_MEMORY = 1
+    feature_matrix.enable_feature(feature_matrix.Feature.BULK_MEMORY, 'SHARED_MEMORY', override=True)
 
   if 'DISABLE_EXCEPTION_CATCHING' in user_settings and 'EXCEPTION_CATCHING_ALLOWED' in user_settings:
     # If we get here then the user specified both DISABLE_EXCEPTION_CATCHING and EXCEPTION_CATCHING_ALLOWED

src/settings_internal.js

@@ -254,8 +254,6 @@ var POST_JS_FILES = [];
 // Set when -pthread / -sPTHREADS is passed
 var PTHREADS = false;
 
-var BULK_MEMORY = false;
-
 var MINIFY_WHITESPACE = true;
 
 var ASYNCIFY_IMPORTS_EXCEPT_JS_LIBS = [];

tools/cmdline.py

@@ -520,12 +520,10 @@ def consume_arg_file():
       settings.DISABLE_EXCEPTION_THROWING = 1
       settings.WASM_EXCEPTIONS = 0
     elif arg == '-mbulk-memory':
-      settings.BULK_MEMORY = 1
       feature_matrix.enable_feature(feature_matrix.Feature.BULK_MEMORY,
                                     '-mbulk-memory',
                                     override=True)
     elif arg == '-mno-bulk-memory':
-      settings.BULK_MEMORY = 0
       feature_matrix.disable_feature(feature_matrix.Feature.BULK_MEMORY)
     elif arg == '-msign-ext':
       feature_matrix.enable_feature(feature_matrix.Feature.SIGN_EXT,

tools/link.py

@@ -1473,8 +1473,6 @@ def limit_incoming_module_api():
   # TODO(sbc): Find make a generic way to expose the feature matrix to JS
   # compiler rather then adding them all ad-hoc as internal settings
   settings.SUPPORTS_PROMISE_ANY = feature_matrix.caniuse(feature_matrix.Feature.PROMISE_ANY)
-  if not settings.BULK_MEMORY:
-    settings.BULK_MEMORY = feature_matrix.caniuse(feature_matrix.Feature.BULK_MEMORY)
   default_setting('WASM_BIGINT', feature_matrix.caniuse(feature_matrix.Feature.JS_BIGINT_INTEGRATION))
 
   if settings.AUDIO_WORKLET:

tools/settings.py

@@ -95,7 +95,6 @@
     'SUPPORT_LONGJMP',
     'WASM_OBJECT_FILES',
     'WASM_WORKERS',
-    'BULK_MEMORY',
 
     # Internal settings used during compilation
     'EXCEPTION_CATCHING_ALLOWED',