Skip to content

Commit 67af9a8

Browse files
committed
[file_packager] Remove unused errback fetchRemovePackage. NFC
This argument has been used since 3839dd4. Even when this function was first add in 74f3242 the errback callback was only used for the IDB failures, not the fetch failures. Fetch failure were left to propagate to the global error handlers. This is small cleanup in advance of emscripten-core#24893.
1 parent af78792 commit 67af9a8

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

tools/file_packager.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -964,7 +964,7 @@ def generate_js(data_target, data_files, metadata):
964964
}'''.strip()
965965

966966
ret += '''
967-
function fetchRemotePackage(packageName, packageSize, callback, errback) {
967+
function fetchRemotePackage(packageName, packageSize, callback) {
968968
%(node_support_code)s
969969
Module['dataFileDownloads'] ??= {};
970970
fetch(packageName)
@@ -1044,7 +1044,7 @@ def generate_js(data_target, data_files, metadata):
10441044
function preloadFallback(error) {
10451045
console.error(error);
10461046
console.error('falling back to default preload behavior');
1047-
fetchRemotePackage(REMOTE_PACKAGE_NAME, REMOTE_PACKAGE_SIZE, processPackageData, handleError);
1047+
fetchRemotePackage(REMOTE_PACKAGE_NAME, REMOTE_PACKAGE_SIZE, processPackageData);
10481048
};
10491049
10501050
openDatabase()
@@ -1063,8 +1063,7 @@ def generate_js(data_target, data_files, metadata):
10631063
console.error(error);
10641064
processPackageData(packageData);
10651065
});
1066-
}
1067-
, preloadFallback);
1066+
});
10681067
}
10691068
})
10701069
}).catch(preloadFallback);
@@ -1086,7 +1085,7 @@ def generate_js(data_target, data_files, metadata):
10861085
} else {
10871086
fetched = data;
10881087
}
1089-
}, handleError);\n'''
1088+
});\n'''
10901089

10911090
code += '''
10921091
Module['preloadResults'][PACKAGE_NAME] = {fromCache: false};

0 commit comments

Comments
 (0)