Skip to content

Commit 779c8f2

Browse files
authored
Skip jsmathz.test_emscripten_api_export_all (emscripten-core#25622)
Fixes: emscripten-core#25620
1 parent c81dbdd commit 779c8f2

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

test/test_core.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1863,6 +1863,8 @@ def test_set_align(self):
18631863
})
18641864
def test_emscripten_api(self, args):
18651865
if '-sMAIN_MODULE' in args:
1866+
if self.get_setting('JS_MATH'):
1867+
self.skipTest('JS_MATH is not compatible with MAIN_MODULE')
18661868
self.check_dylink()
18671869
self.do_core_test('test_emscripten_api.c', cflags=args)
18681870

tools/link.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1089,9 +1089,10 @@ def limit_incoming_module_api():
10891089

10901090
# Use settings
10911091

1092-
if settings.JS_MATH:
1093-
if settings.MAIN_MODULE == 1:
1094-
exit_with_error('JS_MATH is not compatible with dynamic linking (MAIN_MODULE=1)')
1092+
if settings.JS_MATH and settings.MAIN_MODULE == 1:
1093+
# MODULE_MODULE=1 adds`--whole-archive` around all the system libraries which
1094+
# results in duplicate math symbols when JS_MATH is used.
1095+
exit_with_error('JS_MATH is not compatible with dynamic linking (MAIN_MODULE=1)')
10951096

10961097
if settings.WASM == 2 and settings.SINGLE_FILE:
10971098
exit_with_error('cannot have both WASM=2 and SINGLE_FILE enabled at the same time')

0 commit comments

Comments
 (0)