Enable unused-parameter check in ruff. NFC (emscripten-core#23467)

This leads to some useful cleanups!

Author: sbc100

emcc.py

@@ -650,15 +650,15 @@ def run(args):
   # settings until we reach the linking phase.
   settings.limit_settings(COMPILE_TIME_SETTINGS)
 
-  phase_setup(options, state, newargs)
+  phase_setup(options, state)
 
   if options.reproduce:
     create_reproduce_file(options.reproduce, args)
 
   if state.mode == Mode.POST_LINK_ONLY:
     if len(options.input_files) != 1:
       exit_with_error('--post-link requires a single input file')
-    separate_linker_flags(options, state, newargs)
+    separate_linker_flags(state, newargs)
     # Delay import of link.py to avoid processing this file when only compiling
     from tools import link
     link.run_post_link(options.input_files[0], options, state)
@@ -743,7 +743,7 @@ def phase_parse_arguments(state):
   return options, newargs
 
 
-def separate_linker_flags(options, state, newargs):
+def separate_linker_flags(state, newargs):
   newargs = list(newargs)
 
   if settings.RUNTIME_LINKED_LIBS:
@@ -819,7 +819,7 @@ def get_next_arg():
 
 
 @ToolchainProfiler.profile_block('setup')
-def phase_setup(options, state, newargs):
+def phase_setup(options, state):
   """Second phase: configure and setup the compiler based on the specified settings and arguments.
   """
 
@@ -994,7 +994,7 @@ def get_clang_command_asm():
   # filter out the link flags
   assert state.mode == Mode.COMPILE_AND_LINK
   assert not options.dash_c
-  compile_args, input_files = separate_linker_flags(options, state, newargs)
+  compile_args, input_files = separate_linker_flags(state, newargs)
   compile_args = filter_out_link_flags(compile_args)
   linker_inputs = []
   seen_names = {}

pyproject.toml

@@ -27,7 +27,6 @@ lint.select = [
 ]
 
 lint.ignore = [
-  "ARG001",
   "ARG002",
   "ARG005",
   "B006",
@@ -50,6 +49,8 @@ lint.ignore = [
   "PLW2901",
 ]
 lint.per-file-ignores."emrun.py" = [ "PLE0704" ]
+lint.per-file-ignores."tools/ports/*.py" = [ "ARG001" ]
+lint.per-file-ignores."test/other/ports/*.py" = [ "ARG001" ]
 lint.mccabe.max-complexity = 51 # Recommended: 10
 lint.pylint.allow-magic-value-types = [
   "bytes",

test/common.py

@@ -1644,7 +1644,6 @@ def get_library(self, name, generated_libs, configure=['sh', './configure'],  #
       make_args = ['-j', str(shared.get_num_cores())]
 
     build_dir = self.get_build_dir()
-    output_dir = self.get_dir()
 
     emcc_args = []
     if not native:
@@ -1677,7 +1676,7 @@ def get_library(self, name, generated_libs, configure=['sh', './configure'],  #
     cflags = ' '.join(emcc_args)
     env_init.setdefault('CFLAGS', cflags)
     env_init.setdefault('CXXFLAGS', cflags)
-    return build_library(name, build_dir, output_dir, generated_libs, configure,
+    return build_library(name, build_dir, generated_libs, configure,
                          make, make_args, self.library_cache,
                          cache_name, env_init=env_init, native=native)
 
@@ -2359,7 +2358,6 @@ def btest(self, filename, expected=None,
 
 def build_library(name,
                   build_dir,
-                  output_dir,
                   generated_libs,
                   configure,
                   make,

test/runner.py

@@ -364,7 +364,7 @@ def run_tests(options, suites):
   return num_failures
 
 
-def parse_args(args):
+def parse_args():
   parser = argparse.ArgumentParser(prog='runner.py', description=__doc__)
   parser.add_argument('--save-dir', action='store_true',
                       help='Save the temporary directory used during for each '
@@ -412,8 +412,8 @@ def configure():
   parallel_testsuite.NUM_CORES = os.environ.get('EMTEST_CORES') or os.environ.get('EMCC_CORES')
 
 
-def main(args):
-  options = parse_args(args)
+def main():
+  options = parse_args()
 
   # Some options make sense being set in the environment, others not-so-much.
   # TODO(sbc): eventually just make these command-line only.
@@ -494,7 +494,7 @@ def prepend_default(arg):
 
 if __name__ == '__main__':
   try:
-    sys.exit(main(sys.argv))
+    sys.exit(main())
   except KeyboardInterrupt:
     logger.warning('KeyboardInterrupt')
     sys.exit(1)

test/test_benchmark.py

@@ -1109,7 +1109,7 @@ def test_zzz_poppler(self):
       }
     ''' % DEFAULT_ARG)
 
-    def lib_builder(name, native, env_init):
+    def lib_builder(name, native, env_init):  # noqa
       return self.get_poppler_library(env_init=env_init)
 
     # TODO: Fix poppler native build and remove skip_native=True

test/test_browser.py

@@ -31,7 +31,7 @@
 from tools.utils import delete_dir
 
 
-def test_chunked_synchronous_xhr_server(support_byte_ranges, chunkSize, data, checksum, port):
+def test_chunked_synchronous_xhr_server(support_byte_ranges, data, port):
   class ChunkedServerHandler(BaseHTTPRequestHandler):
     def sendheaders(s, extra=None, length=None):
       length = length or len(data)
@@ -1722,7 +1722,7 @@ def test_chunked_synchronous_xhr(self):
     data = os.urandom(10 * chunkSize + 1) # 10 full chunks and one 1 byte chunk
     checksum = zlib.adler32(data) & 0xffffffff # Python 2 compatibility: force bigint
 
-    server = multiprocessing.Process(target=test_chunked_synchronous_xhr_server, args=(True, chunkSize, data, checksum, self.PORT))
+    server = multiprocessing.Process(target=test_chunked_synchronous_xhr_server, args=(True, data, self.PORT))
     server.start()
 
     # block until the server is actually ready

tools/link.py

@@ -1909,7 +1909,7 @@ def phase_link(linker_arguments, wasm_target, js_syms):
 
 
 @ToolchainProfiler.profile_block('post link')
-def phase_post_link(options, state, in_wasm, wasm_target, target, js_syms, base_metadata=None, linker_inputs=None):
+def phase_post_link(options, in_wasm, wasm_target, target, js_syms, base_metadata=None, linker_inputs=None):
   global final_js
 
   target_basename = unsuffixed_basename(target)
@@ -1941,7 +1941,7 @@ def phase_post_link(options, state, in_wasm, wasm_target, target, js_syms, base_
 
   # If we are not emitting any JS then we are all done now
   if options.oformat != OFormat.WASM:
-    phase_final_emitting(options, state, target, js_target, wasm_target)
+    phase_final_emitting(options, target, js_target, wasm_target)
 
 
 @ToolchainProfiler.profile_block('emscript')
@@ -2110,7 +2110,7 @@ def create_worker_file(input_file, target_dir, output_file, options):
 
 
 @ToolchainProfiler.profile_block('final emitting')
-def phase_final_emitting(options, state, target, js_target, wasm_target):
+def phase_final_emitting(options, target, js_target, wasm_target):
   global final_js
 
   if shared.SKIP_SUBPROCS:
@@ -3100,7 +3100,7 @@ def run_post_link(wasm_input, options, state):
   settings.limit_settings(None)
   target, wasm_target = phase_linker_setup(options, state)
   process_libraries(state)
-  phase_post_link(options, state, wasm_input, wasm_target, target, {})
+  phase_post_link(options, wasm_input, wasm_target, target, {})
 
 
 def run(linker_inputs, options, state):
@@ -3171,6 +3171,6 @@ def add_js_deps(sym):
 
   # Perform post-link steps (unless we are running bare mode)
   if options.oformat != OFormat.BARE:
-    phase_post_link(options, state, wasm_target, wasm_target, target, js_syms, base_metadata, linker_inputs)
+    phase_post_link(options, wasm_target, wasm_target, target, js_syms, base_metadata, linker_inputs)
 
   return 0

tools/maint/rebaseline_tests.py

@@ -62,7 +62,7 @@ def process_changed_file(filename):
   return f'{filename}: {old_size} => {size} [{delta:+} bytes / {percent_delta:+.2f}%]\n'
 
 
-def main(argv):
+def main():
   parser = argparse.ArgumentParser()
   parser.add_argument('-s', '--skip-tests', action='store_true', help="Don't actually run the tests, just analyze the existing results")
   parser.add_argument('-b', '--new-branch', action='store_true', help='Create a new branch containing the updates')
@@ -131,4 +131,4 @@ def main(argv):
 
 
 if __name__ == '__main__':
-  sys.exit(main(sys.argv))
+  sys.exit(main())