Skip to content

Commit cae15c8

Browse files
committed
Bump min supported node version from 10.19 to 12.20
This is the minimum node version that we support targeting. Bumping to v12.20 specifically allows us to start using `node:xx` for imports. See emscripten-core#18235
1 parent 3f29dc6 commit cae15c8

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

.circleci/config.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -774,10 +774,10 @@ jobs:
774774
# support in the generated code.
775775
# Keep this in sync with `OLDEST_SUPPORTED_NODE` in `feature_matrix.py`
776776
- install-node-version:
777-
node_version: "10.19.0"
777+
node_version: "12.20.0"
778778
- run-tests:
779-
title: "node (oldest / 10.19.0)"
780-
extra-cflags: "-sMIN_NODE_VERSION=101900"
779+
title: "node (oldest / 12.20.0)"
780+
extra-cflags: "-sMIN_NODE_VERSION=122000"
781781
# We include most but not all of the nodefs and node rawfs tests here.
782782
# test_fs_nodefs_rw, test_fs_nodefs_statvfs, and test_unistd_io_nodefs_bigint fail.
783783
test_targets: "

src/settings.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1929,7 +1929,7 @@ var MIN_CHROME_VERSION = 85;
19291929
// distinct from the minimum version required run the emscripten compiler.
19301930
// This version aligns with the current Ubuuntu TLS 20.04 (Focal).
19311931
// Version is encoded in MMmmVV, e.g. 181401 denotes Node 18.14.01.
1932-
// Minimum supported value is 101900, which was released 2020-02-05 (see
1932+
// Minimum supported value is 122000, which was released 2020-11-25 (see
19331933
// feature_matrix.py).
19341934
var MIN_NODE_VERSION = 160000;
19351935

tools/feature_matrix.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,8 @@
2121
OLDEST_SUPPORTED_CHROME = 45 # September 1, 2015
2222
OLDEST_SUPPORTED_FIREFOX = 40 # August 11, 2015
2323
OLDEST_SUPPORTED_SAFARI = 101000 # September 20, 2016
24-
# 10.19.0 is the oldest version of node that we do any testing with.
2524
# Keep this in sync with the test-node-compat in .circleci/config.yml.
26-
OLDEST_SUPPORTED_NODE = 101900
25+
OLDEST_SUPPORTED_NODE = 122000
2726

2827

2928
class Feature(IntEnum):

0 commit comments

Comments
 (0)