Skip to content

Commit cf323dc

Browse files
authored
Enable dylink tests under ubsan (emscripten-core#25606)
I don't remember why these were disabled but the whole `ubsan` suite seems to still pass with this change. I'm not why that missing realloc exports for withBuiltinMalloc were ok in other configs but their absence from this list is clearly and oversight.
1 parent 95d25fa commit cf323dc

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

test/common.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1084,8 +1084,6 @@ def check_dylink(self):
10841084
self.skipTest('dynamic linking not supported with llvm-libc')
10851085
if self.is_wasm2js():
10861086
self.skipTest('dynamic linking not supported with wasm2js')
1087-
if '-fsanitize=undefined' in self.cflags:
1088-
self.skipTest('dynamic linking not supported with UBSan')
10891087
# MEMORY64=2 mode doesn't currently support dynamic linking because
10901088
# The side modules are lowered to wasm32 when they are built, making
10911089
# them unlinkable with wasm64 binaries.

tools/link.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1568,10 +1568,12 @@ def limit_incoming_module_api():
15681568
settings.REQUIRED_EXPORTS += [
15691569
'malloc',
15701570
'calloc',
1571+
'realloc',
15711572
'memalign',
15721573
'free',
15731574
'emscripten_builtin_malloc',
15741575
'emscripten_builtin_calloc',
1576+
'emscripten_builtin_realloc',
15751577
'emscripten_builtin_memalign',
15761578
'emscripten_builtin_free',
15771579
]

0 commit comments

Comments
 (0)